Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2243)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/notifications/notification_conversion_helper.h

Issue 1135213004: Returning error when NotificationConversionHelper::NotificationBitmapToGfxImage() get failed in not… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes as per review comments. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/extensions/api/notifications/notifications_api.cc ('K') | « chrome/browser/extensions/api/notifications/notifications_api.cc ('k') | chrome/browser/notifications/notification_conversion_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/notifications/notification_conversion_helper.h
diff --git a/chrome/browser/notifications/notification_conversion_helper.h b/chrome/browser/notifications/notification_conversion_helper.h
index de924e7673cd9177033c9880ad021abd6cfd9986..d78bbc4ed48e24219efd919c4fde614e4451fdad 100644
--- a/chrome/browser/notifications/notification_conversion_helper.h
+++ b/chrome/browser/notifications/notification_conversion_helper.h
@@ -42,7 +42,8 @@ class NotificationConversionHelper {
static bool NotificationBitmapToGfxImage(
float max_scale,
const gfx::Size& target_size_dips,
- extensions::api::notifications::NotificationBitmap* notification_bitmap,
+ const extensions::api::notifications::NotificationBitmap&
+ notification_bitmap,
gfx::Image* return_image);
private:
« chrome/browser/extensions/api/notifications/notifications_api.cc ('K') | « chrome/browser/extensions/api/notifications/notifications_api.cc ('k') | chrome/browser/notifications/notification_conversion_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698