Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1767)

Unified Diff: chrome/browser/notifications/notification_conversion_helper.cc

Issue 1135213004: Returning error when NotificationConversionHelper::NotificationBitmapToGfxImage() get failed in not… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes as per review comments. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification_conversion_helper.cc
diff --git a/chrome/browser/notifications/notification_conversion_helper.cc b/chrome/browser/notifications/notification_conversion_helper.cc
index 4434af17bedbf677f4c0aa2da6223e3d6ebb0988..13dbdb3e98c8e764277b2310c902cafbd29e5269 100644
--- a/chrome/browser/notifications/notification_conversion_helper.cc
+++ b/chrome/browser/notifications/notification_conversion_helper.cc
@@ -144,8 +144,7 @@ bool NotificationConversionHelper::NotificationBitmapToGfxImage(
const gfx::Size& target_size_dips,
extensions::api::notifications::NotificationBitmap* notification_bitmap,
dewittj 2015/05/22 16:42:24 Let's change this to take a const extensions::api:
Deepak 2015/05/23 14:03:40 Done.
gfx::Image* return_image) {
- if (!notification_bitmap)
- return false;
+ DCHECK(notification_bitmap);
const int max_device_pixel_width = target_size_dips.width() * max_scale;
const int max_device_pixel_height = target_size_dips.height() * max_scale;

Powered by Google App Engine
This is Rietveld 408576698