Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 1135203005: Implement keycode text conversion functions for Ozone. (Closed)

Created:
5 years, 7 months ago by samuong
Modified:
5 years, 7 months ago
Reviewers:
stgao, kpschoedel
CC:
chromium-reviews, samuong+watch_chromium.org, stgao
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement keycode text conversion functions for Ozone. BUG=413075 Committed: https://crrev.com/3e86f2231ea55908721b264d00e679aa25ecf03b Cr-Commit-Position: refs/heads/master@{#329693}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -19 lines) Patch
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/chromedriver/keycode_text_conversion_ozone.cc View 1 chunk +82 lines, -15 lines 0 comments Download
M chrome/test/chromedriver/keycode_text_conversion_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
samuong
Shuotao, this CL contains an Ozone implementation of the keycode converter for ChromeDriver, which is ...
5 years, 7 months ago (2015-05-12 22:54:49 UTC) #2
kpschoedel
LGTM as the Ozone equivalent of the X11 code.
5 years, 7 months ago (2015-05-13 16:07:02 UTC) #3
stgao
lgtm
5 years, 7 months ago (2015-05-13 18:03:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135203005/1
5 years, 7 months ago (2015-05-13 18:08:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 19:11:13 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 19:12:57 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e86f2231ea55908721b264d00e679aa25ecf03b
Cr-Commit-Position: refs/heads/master@{#329693}

Powered by Google App Engine
This is Rietveld 408576698