Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1135203002: Add <link rel=preconnect> crossorigin attribute (take 2) (Closed)

Created:
5 years, 7 months ago by Yoav Weiss
Modified:
5 years, 7 months ago
Reviewers:
Mike West
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink, gavinp+prerender_chromium.org, gavinp+loader_chromium.org, Nate Chapin, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add <link rel=preconnect> crossorigin attribute (take 2) A second attempt to land https://codereview.chromium.org/1138743002/ In order to support preconnect for both anonymous and non-anonymous connection pools we need to add support for the crossorigin attribute in <link rel=preconnect>. This CL implements the core functionality of this change on the Blink side. BUG=468005 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195236

Patch Set 1 #

Patch Set 2 : Add call to new WebPrescientNetworking interface when crossorigin is used #

Patch Set 3 : Todo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -21 lines) Patch
A LayoutTests/fast/dom/HTMLLinkElement/link-preconnect-crossorigin.html View 1 chunk +14 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/HTMLLinkElement/link-preconnect-crossorigin-expected.txt View 1 chunk +9 lines, -0 lines 0 comments Download
A + LayoutTests/fast/dom/HTMLLinkElement/link-preconnect-valid.html View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/fast/dom/HTMLLinkElement/link-preconnect-valid-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A Source/core/html/CrossOriginAttribute.h View 1 chunk +19 lines, -0 lines 0 comments Download
A Source/core/html/CrossOriginAttribute.cpp View 1 chunk +20 lines, -0 lines 0 comments Download
M Source/core/loader/LinkHeader.h View 3 chunks +4 lines, -0 lines 0 comments Download
M Source/core/loader/LinkHeader.cpp View 7 chunks +17 lines, -6 lines 0 comments Download
M Source/core/loader/LinkHeaderTest.cpp View 3 chunks +31 lines, -5 lines 0 comments Download
M Source/core/loader/LinkLoader.cpp View 4 chunks +12 lines, -5 lines 0 comments Download
M Source/platform/network/NetworkHints.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/platform/network/NetworkHints.cpp View 1 2 1 chunk +8 lines, -3 lines 0 comments Download
A public/platform/WebCrossOriginAttribute.h View 1 chunk +19 lines, -0 lines 0 comments Download
M public/platform/WebPrescientNetworking.h View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Yoav Weiss
Hey Mike, Can you review? The only difference from https://codereview.chromium.org/1138743002/ is that preconnect calls the ...
5 years, 7 months ago (2015-05-12 07:16:34 UTC) #2
Mike West
On 2015/05/12 at 07:16:34, yoav wrote: > Hey Mike, > > Can you review? The ...
5 years, 7 months ago (2015-05-12 07:17:46 UTC) #3
Yoav Weiss
On 2015/05/12 07:17:46, Mike West wrote: > On 2015/05/12 at 07:16:34, yoav wrote: > > ...
5 years, 7 months ago (2015-05-12 07:24:51 UTC) #4
Mike West
LGTM.
5 years, 7 months ago (2015-05-12 07:44:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135203002/1
5 years, 7 months ago (2015-05-12 07:45:40 UTC) #7
Yoav Weiss
On 2015/05/12 07:45:40, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
5 years, 7 months ago (2015-05-12 08:58:24 UTC) #9
Mike West
On 2015/05/12 at 08:58:24, yoav wrote: > On 2015/05/12 07:45:40, I haz the power (commit-bot) ...
5 years, 7 months ago (2015-05-12 09:08:09 UTC) #10
Yoav Weiss
On 2015/05/12 09:08:09, Mike West wrote: > On 2015/05/12 at 08:58:24, yoav wrote: > > ...
5 years, 7 months ago (2015-05-12 09:42:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135203002/40001
5 years, 7 months ago (2015-05-12 10:43:35 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 10:47:52 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195236

Powered by Google App Engine
This is Rietveld 408576698