Add a class for management of thermal throttling

build/android/pylib/perf_tests_helper.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import re
+import logging
 
 import android_commands
 import math
 
 # Valid values of result type.
 RESULT_TYPES = {'unimportant': 'RESULT ',
                 'default': '*RESULT ',
                 'informational': ''}
 
 
@@ skipping 95 matching lines @@
   def TearDown(self):
     """Tears down performance tests."""
     if self._original_scaling_governor:
       self._SetScalingGovernorInternal(self._original_scaling_governor)
     self._original_scaling_governor = None
 
   def _SetScalingGovernorInternal(self, value):
     for cpu in range(self._num_cpus):
       self._adb.RunShellCommand(
           ('echo %s > ' + PerfTestSetup._SCALING_GOVERNOR) % (value, cpu))
+
+
+class ThermalThrottle(object):

[bulach, 2012/10/31 10:44:47]

it'd make sense to have this class in its own file in this directory,
thermal_throttle.py

[Anthony Berent, 2012/10/31 15:14:02]

Done.

+  """Class to detect and track thermal throttling
+
+  Usage:
+    Wait for IsThrottled() to be False before running test
+    After running test call HasBeenThrottled() to find out if the
+    test run was affected by thermal throttling.
+
+    Currently assumes an OMap device, but I don't know of any others with

[bulach, 2012/10/31 10:44:47]

nit: people told me in the past to avoid using first person.. probably best to
just remove the last sentence and just keep "Assumes an OMap device." ? 

[Anthony Berent, 2012/10/31 15:14:02]

Done.

+    thermal throttling.
+  """
+  _throttled = False

[bulach, 2012/10/31 10:44:47]

nit: this should be a regular member in __init__ (afaict, here it's a static
member)

[Anthony Berent, 2012/10/31 15:14:02]

Done.

+
+  def __init__(self, adb):
+    self._adb = adb
+
+  def HasBeenThrottled(self):
+    """ True if there has been any throttling since the last call to
+        HasBeenThrottled or IsThrottled
+    """
+    return self._readLog()
+
+  def IsThrottled(self):
+    """True if currently throttled"""
+    self._readLog()
+    return self._throttled
+
+  def _readLog(self):

[bulach, 2012/10/31 10:44:47]

nit: _ReadLog

[Anthony Berent, 2012/10/31 15:14:02]

Done.

+    has_been_throttled = False
+    log = self._adb.RunShellCommand("dmesg -c")

[bulach, 2012/10/31 10:44:47]

nit: single quotes on all strings here.

[Anthony Berent, 2012/10/31 15:14:02]

Done.

+    for line in log:
+      if "omap_thermal_throttle" in line:
+        if not self._throttled:
+          logging.warning(">>> Thermally Throttled")
+        self._throttled = True
+        has_been_throttled = True
+      if "omap_thermal_unthrottle" in line:
+        if self._throttled:
+          logging.warning(">>> Thermally Unthrottled")
+        self._throttled = False
+        has_been_throttled = True
+    return has_been_throttled
+