Issue 1135193003: Remove the extra copy of page id.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1135193003: Remove the extra copy of page id. (Closed)

Created:
5 years, 7 months ago by Avi (use Gerrit)

Modified:
5 years, 5 months ago

Reviewers:
Charlie Reis

CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@kill1

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove the extra copy of page id. BUG=369661 TEST=All tests remain green.

Patch Set 1 #

Total comments: 1

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -31 lines)			Patch
M	content/browser/frame_host/render_frame_host_impl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/frame_host/render_frame_host_impl.cc	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host_impl.h	View	1 chunk	+0 lines, -5 lines	1 comment	Download
M	content/browser/renderer_host/render_view_host_impl.cc	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	content/common/frame_messages.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	content/common/swapped_out_messages.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	content/renderer/render_frame_impl.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Charlie Reis

5 years, 7 months ago (2015-05-13 17:17:51 UTC) #2

https://codereview.chromium.org/1135193003/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_view_host_impl.h (left):

https://codereview.chromium.org/1135193003/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_view_host_impl.h:416: int32 page_id_;
To get UpdateTitle and UpdateState to work when cross-process navigations may
have recently committed, I think we need each RVH (or RFH?) to know which
NavigationEntry it's on.

We don't need page ID for this (since it's going away), but we need something. 
Unique ID would probably work.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages