Ensure EasyUnlockPrivateAPI factory is initialized on start up.

Ensure EasyUnlockPrivateAPI factory is initialized on start up.

BUG=487486
Committed: https://crrev.com/3b7173a8d1b6c445ae93f616fe742ddf57efd8c4
Cr-Commit-Position: refs/heads/master@{#329974}

[Tim Song, 2015-05-12 01:41:28]

tengs@chromium.org changed reviewers:
+ pneubeck@chromium.org, scheib@chromium.org

[scheib, 2015-05-12 03:15:27]

LGTM

api:: namespace stands out here doesn't it.

BUG number on description, please.

[Tim Song, 2015-05-13 02:33:13]

I moved the EasyUnlockPrivateAPI out of the api namespace to be consistent.

[scheib, 2015-05-13 04:13:52]

LGTM still

[Tim Song, 2015-05-14 17:27:12]

The CQ bit was checked by tengs@chromium.org

[Tim Song, 2015-05-14 17:27:12]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/1135183002/#ps40001
(title: "fix unit test")

[commit-bot: I haz the power, 2015-05-14 17:28:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1135183002/40001

[commit-bot: I haz the power, 2015-05-14 18:31:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-14 18:31:13]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Tim Song, 2015-05-14 20:18:02]

tengs@chromium.org changed reviewers:
+ tbarzic@chromium.org

[Tim Song, 2015-05-14 20:18:04]

+tbarzic@

Toni, I lazily intialize the EasyUnlockPrivateCryptoDelegate because DBusManager
is not created when the API factories are created. Let me know if this looks
okay to you.

[tbarzic, 2015-05-14 20:22:45]

lgtm

https://codereview.chromium.org/1135183002/diff/60001/chrome/browser/extensio...
File chrome/browser/extensions/browser_context_keyed_service_factories.cc
(right):

https://codereview.chromium.org/1135183002/diff/60001/chrome/browser/extensio...
chrome/browser/extensions/browser_context_keyed_service_factories.cc:98: //
extensions::EasyUnlockPrivateAPI::GetFactoryInstance();
remove comment

[Tim Song, 2015-05-14 22:01:07]

https://codereview.chromium.org/1135183002/diff/60001/chrome/browser/extensio...
File chrome/browser/extensions/browser_context_keyed_service_factories.cc
(right):

https://codereview.chromium.org/1135183002/diff/60001/chrome/browser/extensio...
chrome/browser/extensions/browser_context_keyed_service_factories.cc:98: //
extensions::EasyUnlockPrivateAPI::GetFactoryInstance();
On 2015/05/14 20:22:44, tbarzic wrote:
> remove comment

Done.

[Tim Song, 2015-05-14 23:16:09]

The CQ bit was checked by tengs@chromium.org

[Tim Song, 2015-05-14 23:16:09]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org,
tbarzic@chromium.org
Link to the patchset: https://codereview.chromium.org/1135183002/#ps80001
(title: "uncomment")

[commit-bot: I haz the power, 2015-05-14 23:17:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1135183002/80001

[commit-bot: I haz the power, 2015-05-14 23:37:30]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-05-14 23:38:12]

Patchset 5 (id:??) landed as
https://crrev.com/3b7173a8d1b6c445ae93f616fe742ddf57efd8c4
Cr-Commit-Position: refs/heads/master@{#329974}

[pneubeck (no reviews), 2015-05-15 08:55:06]

On 2015/05/14 20:18:04, Tim Song wrote:
> +tbarzic@
> 
> Toni, I lazily intialize the EasyUnlockPrivateCryptoDelegate because
DBusManager
> is not created when the API factories are created. Let me know if this looks
> okay to you.

I looked further into this, as it was not clear to me _why_ the API class is
affecting profile creation. If the API object is created lazily, i.e. when the
API is used the first time, this should not have any conflict with dbus.

It turns out, that the BrowserContextKeyedAPIFactory is by default created
during profile creation, which IMO is just wrong: see
https://code.google.com/p/chromium/codesearch#chromium/src/extensions/browser...

APIs should be lazily initialized on first use. I'll through out a CL to fix
this default.