tools/telemetry/telemetry/page/page_test.py - Issue 1135173007: Kill page_test.NavigateToPage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_test.py

Issue 1135173007: Kill page_test.NavigateToPage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@KillNavigateToPage

Patch Set: Address sclittle's comment Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/page/page_test.py

diff --git a/tools/telemetry/telemetry/page/page_test.py b/tools/telemetry/telemetry/page/page_test.py

index e992abb08892af5f83981ac7f23b0c0faca0907a..7a931a599e64c8e71a45703feed86c0fb03b03d4 100644

--- a/tools/telemetry/telemetry/page/page_test.py

+++ b/tools/telemetry/telemetry/page/page_test.py

@@ -192,6 +192,7 @@ class PageTest(object):

"""

raise NotImplementedError

+ # Deprecated: do not use this hook. (crbug.com/470147)

def RunNavigateSteps(self, page, tab):

"""Navigates the tab to the page URL attribute.

« no previous file with comments | « tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/safebrowsing.py ('k') | no next file » | no next file with comments »