Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: tools/chrome_proxy/common/chrome_proxy_measurements.py

Issue 1135173007: Kill page_test.NavigateToPage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@KillNavigateToPage
Patch Set: rebaase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/chrome_proxy/common/chrome_proxy_measurements.py
diff --git a/tools/chrome_proxy/common/chrome_proxy_measurements.py b/tools/chrome_proxy/common/chrome_proxy_measurements.py
index ab8fd671a5e8897becdf4d91d088673dc910de3a..eb42e0a2c1c2059263d7ec4b3c1153981f7fddfa 100644
--- a/tools/chrome_proxy/common/chrome_proxy_measurements.py
+++ b/tools/chrome_proxy/common/chrome_proxy_measurements.py
@@ -50,10 +50,6 @@ class ChromeProxyValidation(page_test.PageTest):
return True
return False
- def RunNavigateSteps(self, page, tab):
- # The redirect from safebrowsing causes a timeout. Ignore that.
- try:
- super(ChromeProxyValidation, self).RunNavigateSteps(page, tab)
if self._expect_timeout:
sclittle 2015/05/19 19:58:57 This is syntactically incorrect without the "try",
nednguyen 2015/05/19 20:18:01 Err, silly me. I am about to remove the whole RunN
raise metrics.ChromeProxyMetricException, (
'Timeout was expected, but did not occur')

Powered by Google App Engine
This is Rietveld 408576698