Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/safebrowsing.py

Issue 1135173007: Kill page_test.NavigateToPage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@KillNavigateToPage
Patch Set: rebaase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4 #
5 from telemetry.core import exceptions
5 from telemetry.page import page as page_module 6 from telemetry.page import page as page_module
6 from telemetry.page import page_set as page_set_module 7 from telemetry.page import page_set as page_set_module
7 8
8 9
9 class SafebrowsingPage(page_module.Page): 10 class SafebrowsingPage(page_module.Page):
10 11
11 """ 12 """
12 Why: Expect 'malware ahead' page. Use a short navigation timeout because no 13 Why: Expect 'malware ahead' page. Use a short navigation timeout because no
13 response will be received. 14 response will be received.
14 """ 15 """
15 16
16 def __init__(self, url, page_set): 17 def __init__(self, url, page_set, expect_timeout):
17 super(SafebrowsingPage, self).__init__(url=url, page_set=page_set) 18 super(SafebrowsingPage, self).__init__(url=url, page_set=page_set)
18 self.archive_data_file = '../data/chrome_proxy_safebrowsing.json' 19 self.archive_data_file = '../data/chrome_proxy_safebrowsing.json'
20 self._expect_timeout = expect_timeout
19 21
20 def RunNavigateSteps(self, action_runner): 22 def RunNavigateSteps(self, action_runner):
21 action_runner.Navigate(self.url, timeout_in_seconds=5) 23 try:
24 action_runner.Navigate(self.url, timeout_in_seconds=5)
25 except exceptions.TimeoutException as e:
26 if self._expect_timeout:
27 logging.warning('Navigation timeout on page %s', self.url)
28 else:
29 raise e
22 30
23 31
24 class SafebrowsingPageSet(page_set_module.PageSet): 32 class SafebrowsingPageSet(page_set_module.PageSet):
25 33
26 """ Chrome proxy test sites """ 34 """ Chrome proxy test sites """
27 35
28 def __init__(self): 36 def __init__(self, expect_timeout=False):
29 super(SafebrowsingPageSet, self).__init__( 37 super(SafebrowsingPageSet, self).__init__(
30 archive_data_file='../data/chrome_proxy_safebrowsing.json') 38 archive_data_file='../data/chrome_proxy_safebrowsing.json')
31 39
32 self.AddUserStory(SafebrowsingPage('http://www.ianfette.org/', self)) 40 self.AddUserStory(
41 SafebrowsingPage('http://www.ianfette.org/', self, expect_timeout))
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698