Kill page_test.NavigateToPage

tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from common.chrome_proxy_benchmark import ChromeProxyBenchmark
 from integration_tests import chrome_proxy_pagesets as pagesets
 from integration_tests import chrome_proxy_measurements as measurements
 from telemetry import benchmark
 from telemetry.core.backends.chrome import android_browser_finder
 
@@ skipping 71 matching lines @@
   @classmethod
   def Name(cls):
     return 'chrome_proxy_benchmark.block_once.block_once'
 
 
 @benchmark.Enabled(*ANDROID_CHROME_BROWSERS)
 # Safebrowsing is enabled for Android and iOS.
 class ChromeProxySafeBrowsingOn(ChromeProxyBenchmark):
   tag = 'safebrowsing_on'
   test = measurements.ChromeProxySafebrowsingOn
-  page_set = pagesets.SafebrowsingPageSet
+
+  def CreateUserStorySet(self, options):

[sclittle, 2015/05/19 19:58:57]

Why is this benchmark being changed to not use |page_set|, but the other
benchmarks aren't?

[nednguyen, 2015/05/19 20:18:01]

Because we need to instantiate the pagesets.SafebrowsingPageSet. By default,
telemetry benchmark just directly construct the page_set object.

+    del options  # unused
+    return pagesets.SafebrowsingPageSet(expect_timeout=True)
 
   @classmethod
   def Name(cls):
     return 'chrome_proxy_benchmark.safebrowsing_on.safebrowsing'
 
 
 @benchmark.Disabled(*ANDROID_CHROME_BROWSERS)
 # Safebrowsing is switched off for Android Webview and all desktop platforms.
 class ChromeProxySafeBrowsingOff(ChromeProxyBenchmark):
   tag = 'safebrowsing_off'
@@ skipping 46 matching lines @@
 
 
 class ChromeProxySmoke(ChromeProxyBenchmark):
   tag = 'smoke'
   test = measurements.ChromeProxySmoke
   page_set = pagesets.SmokePageSet
 
   @classmethod
   def Name(cls):
     return 'chrome_proxy_benchmark.smoke.smoke'