Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: chrome/browser/autocomplete/autocomplete_provider_unittest.cc

Issue 1135163002: Omnibox - Strip Extra Whitespace from Custom Search Engine Names (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix more tests that don't set short_name Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/autocomplete/history_quick_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autocomplete/autocomplete_provider_unittest.cc
diff --git a/chrome/browser/autocomplete/autocomplete_provider_unittest.cc b/chrome/browser/autocomplete/autocomplete_provider_unittest.cc
index 560990929e5d2d03222457b3e8005e02b657e685..003b4882e270bf1c5119678cedcb1f7a081b67f3 100644
--- a/chrome/browser/autocomplete/autocomplete_provider_unittest.cc
+++ b/chrome/browser/autocomplete/autocomplete_provider_unittest.cc
@@ -249,6 +249,7 @@ void AutocompleteProviderTest::RegisterTemplateURL(
}
TemplateURLData data;
data.SetURL(template_url);
+ data.SetShortName(keyword);
data.SetKeyword(keyword);
TemplateURL* default_t_url = new TemplateURL(data);
TemplateURLService* turl_model =
@@ -324,6 +325,8 @@ void AutocompleteProviderTest::
// Reset the default TemplateURL.
TemplateURLData data;
+ data.SetShortName(base::ASCIIToUTF16("default"));
+ data.SetKeyword(base::ASCIIToUTF16("default"));
data.SetURL("http://defaultturl/{searchTerms}");
TemplateURL* default_t_url = new TemplateURL(data);
TemplateURLService* turl_model =
@@ -335,7 +338,7 @@ void AutocompleteProviderTest::
// Create another TemplateURL for KeywordProvider.
TemplateURLData data2;
- data2.short_name = base::ASCIIToUTF16("k");
+ data2.SetShortName(base::ASCIIToUTF16("k"));
data2.SetKeyword(base::ASCIIToUTF16("k"));
data2.SetURL("http://keyword/{searchTerms}");
TemplateURL* keyword_t_url = new TemplateURL(data2);
@@ -356,7 +359,7 @@ void AutocompleteProviderTest::ResetControllerWithKeywordProvider() {
// Create a TemplateURL for KeywordProvider.
TemplateURLData data;
- data.short_name = base::ASCIIToUTF16("foo.com");
+ data.SetShortName(base::ASCIIToUTF16("foo.com"));
data.SetKeyword(base::ASCIIToUTF16("foo.com"));
data.SetURL("http://foo.com/{searchTerms}");
TemplateURL* keyword_t_url = new TemplateURL(data);
@@ -365,7 +368,7 @@ void AutocompleteProviderTest::ResetControllerWithKeywordProvider() {
// Make a TemplateURL for KeywordProvider that a shorter version of the
// first.
- data.short_name = base::ASCIIToUTF16("f");
+ data.SetShortName(base::ASCIIToUTF16("f"));
data.SetKeyword(base::ASCIIToUTF16("f"));
data.SetURL("http://f.com/{searchTerms}");
keyword_t_url = new TemplateURL(data);
@@ -373,7 +376,7 @@ void AutocompleteProviderTest::ResetControllerWithKeywordProvider() {
ASSERT_NE(0, keyword_t_url->id());
// Create another TemplateURL for KeywordProvider.
- data.short_name = base::ASCIIToUTF16("bar.com");
+ data.SetShortName(base::ASCIIToUTF16("bar.com"));
data.SetKeyword(base::ASCIIToUTF16("bar.com"));
data.SetURL("http://bar.com/{searchTerms}");
keyword_t_url = new TemplateURL(data);
« no previous file with comments | « no previous file | chrome/browser/autocomplete/history_quick_provider_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698