Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: components/search_engines/template_url_data.h

Issue 1135163002: Omnibox - Strip Extra Whitespace from Custom Search Engine Names (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/search_engines/template_url.cc ('k') | components/search_engines/template_url_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/search_engines/template_url_data.h
diff --git a/components/search_engines/template_url_data.h b/components/search_engines/template_url_data.h
index b460150b109fa20ead76a85fd66b8a31ff4639a8..96389401cb80ea00b9f9df073033514648215013 100644
--- a/components/search_engines/template_url_data.h
+++ b/components/search_engines/template_url_data.h
@@ -23,7 +23,8 @@ struct TemplateURLData {
// A short description of the template. This is the name we show to the user
// in various places that use TemplateURLs. For example, the location bar
// shows this when the user selects a substituting match.
- base::string16 short_name;
+ void SetShortName(const base::string16& shortname);
Peter Kasting 2015/05/11 23:53:17 Nit: Call the arg |short_name|
Mark P 2015/05/12 04:37:38 Done.
+ const base::string16& short_name() const { return short_name_; }
// The shortcut for this TemplateURL. |keyword| must be non-empty.
void SetKeyword(const base::string16& keyword);
@@ -115,6 +116,7 @@ struct TemplateURLData {
private:
// Private so we can enforce using the setters and thus enforce that these
// fields are never empty.
+ base::string16 short_name_;
base::string16 keyword_;
std::string url_;
};
« no previous file with comments | « components/search_engines/template_url.cc ('k') | components/search_engines/template_url_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698