Make DRP bypass logic apply to any proxies that send the DRP via header.

Make DRP bypass logic apply to any proxies that send the DRP via header.

With this change, the Data Reduction Proxy bypass logic will be applied
to any response that either used one of the currently configured Data
Reduction Proxies, or used a different proxy that sent the Data
Reduction Proxy via header.

BUG=476610
Committed: https://crrev.com/f1234f1421642aada2b75b879be98ffcd02efb3e
Cr-Commit-Position: refs/heads/master@{#329277}

[sclittle, 2015-05-11 22:07:53]

sclittle@chromium.org changed reviewers:
+ bengr@chromium.org, jeremyim@chromium.org

[sclittle, 2015-05-11 22:07:53]

PTAL

[jeremyim, 2015-05-11 22:32:53]

https://codereview.chromium.org/1135153002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc
(right):

https://codereview.chromium.org/1135153002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc:115:
data_reduction_proxy_type_info.is_ssl = request->url().SchemeIsSecure();
If there have been instances of HTTPS requests hitting this issue, then this
will continue to fail, since we return false if is_ssl is true (line 119)

[sclittle, 2015-05-11 22:44:11]

https://codereview.chromium.org/1135153002/diff/1/components/data_reduction_p...
File
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc
(right):

https://codereview.chromium.org/1135153002/diff/1/components/data_reduction_p...
components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol.cc:115:
data_reduction_proxy_type_info.is_ssl = request->url().SchemeIsSecure();
On 2015/05/11 22:32:52, jeremyim wrote:
> If there have been instances of HTTPS requests hitting this issue, then this
> will continue to fail, since we return false if is_ssl is true (line 119)

True, but we don't support bypass for the HTTPS tunneling proxy anyways, and
IIUC there's no way the proxy could have added the via header for an HTTPS
response anyways.

This conditional set of |is_ssl| is essentially just here for clarity's sake,
since request->url().SchemeIsSecure() will always be false here. This code
doesn't require it to be false though, so I don't want to put a DCHECK and force
is_ssl = false.

[jeremyim, 2015-05-11 22:50:18]

lgtm

[sclittle, 2015-05-11 22:50:54]

The CQ bit was checked by sclittle@chromium.org

[commit-bot: I haz the power, 2015-05-11 22:53:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1135153002/1

[commit-bot: I haz the power, 2015-05-11 23:46:22]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-05-11 23:47:53]

Patchset 1 (id:??) landed as
https://crrev.com/f1234f1421642aada2b75b879be98ffcd02efb3e
Cr-Commit-Position: refs/heads/master@{#329277}