Handle vmservice messages while at breakpoint.

runtime/vm/service.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/service.h"
 
 #include "vm/cpu.h"
 #include "vm/dart_entry.h"
 #include "vm/debugger.h"
 #include "vm/heap_histogram.h"
@@ skipping 135 matching lines @@
   }
   {
     JSONArray jsarr(&jsobj, "option_values");
     for (intptr_t i = 0; i < js->num_options(); i++) {
       jsarr.AddValue(js->GetOptionValue(i));
     }
   }
 }
 
 
-static void PrintCollectionErrorResponse(const char* collection_name,
-                                         JSONStream* js) {
-  JSONObject jsobj(js);
-  jsobj.AddProperty("type", "error");
-  jsobj.AddPropertyF("text", "Must specify collection object id: /%s/id",
-                     collection_name);
-}
-
-
 static void PrintGenericError(JSONStream* js) {
   JSONObject jsobj(js);
-  jsobj.AddProperty("type", "error");
+  jsobj.AddProperty("type", "Error");
   jsobj.AddProperty("text", "Invalid request.");
   PrintArgumentsAndOptions(jsobj, js);
 }
 
+
+static void PrintError(JSONStream* js, const char* format, ...) {
+  Isolate* isolate = Isolate::Current();
+
+  va_list args;
+  va_start(args, format);
+  intptr_t len = OS::VSNPrint(NULL, 0, format, args);
+  va_end(args);
+
+  char* buffer = isolate->current_zone()->Alloc<char>(len + 1);
+  va_list args2;
+  va_start(args2, format);
+  OS::VSNPrint(buffer, (len + 1), format, args2);
+  va_end(args2);
+
+  JSONObject jsobj(js);
+  jsobj.AddProperty("type", "Error");
+  jsobj.AddProperty("text", buffer);
+  PrintArgumentsAndOptions(jsobj, js);
+}
+
 
 static void HandleName(Isolate* isolate, JSONStream* js) {
   JSONObject jsobj(js);
   jsobj.AddProperty("type", "IsolateName");
   jsobj.AddProperty("id", static_cast<intptr_t>(isolate->main_port()));
   jsobj.AddProperty("name", isolate->name());
 }
 
 
 static void HandleStackTrace(Isolate* isolate, JSONStream* js) {
@@ skipping 15 matching lines @@
     jsobj.AddProperty("function", frame->function());
     jsobj.AddProperty("code", frame->code());
   }
 }
 
 
 static void HandleObjectHistogram(Isolate* isolate, JSONStream* js) {
   ObjectHistogram* histogram = Isolate::Current()->object_histogram();
   if (histogram == NULL) {
     JSONObject jsobj(js);
-    jsobj.AddProperty("type", "error");
+    jsobj.AddProperty("type", "Error");
     jsobj.AddProperty("text", "Run with --print_object_histogram");
     return;
   }
   histogram->PrintToJSONStream(js);
 }
 
 
 static void HandleEcho(Isolate* isolate, JSONStream* js) {
   JSONObject jsobj(js);
   jsobj.AddProperty("type", "message");
   PrintArgumentsAndOptions(jsobj, js);
 }
 
 
 // Print an error message if there is no ID argument.
-#define REQUIRE_COLLECTION_ID(collection)                                      \
-  if (js->num_arguments() == 1) {                                              \
-    PrintCollectionErrorResponse(collection, js);                              \
-    return;                                                                    \
+#define REQUIRE_COLLECTION_ID(collection)                                     \
+  if (js->num_arguments() == 1) {                                             \
+    PrintError(js, "Must specify collection object id: /%s/id", collection);  \
+    return;                                                                   \
   }
 
 
 static void HandleClasses(Isolate* isolate, JSONStream* js) {
   if (js->num_arguments() == 1) {
     ClassTable* table = isolate->class_table();
     table->PrintToJSONStream(js);
     return;
   }
   ASSERT(js->num_arguments() >= 2);
@@ skipping 23 matching lines @@
   REQUIRE_COLLECTION_ID("objects");
   ASSERT(js->num_arguments() >= 2);
   ObjectIdRing* ring = isolate->object_id_ring();
   ASSERT(ring != NULL);
   intptr_t id = atoi(js->GetArgument(1));
   Object& obj = Object::Handle(ring->GetObjectForId(id));
   obj.PrintToJSONStream(js, false);
 }
 
 
+static void HandleDebug(Isolate* isolate, JSONStream* js) {
+  if (js->num_arguments() == 1) {
+    PrintError(js, "Must specify a subcommand");
+    return;
+  }
+  const char* command = js->GetArgument(1);
+  if (!strcmp(command, "breakpoints")) {
+    if (js->num_arguments() == 2) {
+      // Print breakpoint list.
+      JSONObject jsobj(js);
+      jsobj.AddProperty("type", "BreakpointList");
+      JSONArray jsarr(&jsobj, "breakpoints");
+      isolate->debugger()->PrintBreakpointsToJSONArray(&jsarr);
+
+    } else if (js->num_arguments() == 3) {
+      // Print individual breakpoint.
+      intptr_t id = atoi(js->GetArgument(2));
+      SourceBreakpoint* bpt = isolate->debugger()->GetBreakpointById(id);
+      if (bpt != NULL) {
+        bpt->PrintToJSONStream(js);
+      } else {
+        PrintError(js, "Unrecognized breakpoint id %s", js->GetArgument(2));
+      }
+
+    } else {
+      PrintError(js, "Command too long");
+    }
+  } else {
+    PrintError(js, "Unrecognized subcommand '%s'", js->GetArgument(1));
+  }
+}
+
+
 static void HandleCpu(Isolate* isolate, JSONStream* js) {
   JSONObject jsobj(js);
   jsobj.AddProperty("type", "CPU");
   jsobj.AddProperty("architecture", CPU::Id());
 }
 
 
-// Alphabetical order.
 static ServiceMessageHandlerEntry __message_handlers[] = {
   { "_echo", HandleEcho },
   { "classes", HandleClasses },
   { "cpu", HandleCpu },
+  { "debug", HandleDebug },
   { "library", HandleLibrary },
   { "name", HandleName },
   { "objecthistogram", HandleObjectHistogram},
   { "objects", HandleObjects },
   { "stacktrace", HandleStackTrace },
 };
 
 
 static void HandleFallthrough(Isolate* isolate, JSONStream* js) {
   JSONObject jsobj(js);
-  jsobj.AddProperty("type", "error");
+  jsobj.AddProperty("type", "Error");
   jsobj.AddProperty("text", "request not understood.");
   PrintArgumentsAndOptions(jsobj, js);
 }
 
 
 static ServiceMessageHandler FindServiceMessageHandler(const char* command) {
   intptr_t num_message_handlers = sizeof(__message_handlers) /
                                   sizeof(__message_handlers[0]);
   for (intptr_t i = 0; i < num_message_handlers; i++) {
     const ServiceMessageHandlerEntry& entry = __message_handlers[i];
     if (!strcmp(command, entry.command)) {
       return entry.handler;
     }
   }
   return HandleFallthrough;
 }
 
 }  // namespace dart