Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1135123002: Clear the onMessage and onDisconnect listeners when their Extension Port is destroyed. (Closed)

Created:
5 years, 7 months ago by not at google - send to devlin
Modified:
5 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear the onMessage and onDisconnect listeners when their Extension Port is destroyed. I was ambitious in r325585 to remove this behavior, asserting that the Port's owner should clear its own listeners. This is an optimistic expectation, and a backwards incompatible one at any rate. BUG=486715 R=rockot@chromium.org Committed: https://crrev.com/1be1629824f63c62466b44fc90d40101fa9d495a Cr-Commit-Position: refs/heads/master@{#329265}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -21 lines) Patch
M chrome/test/data/extensions/api_test/messaging/connect/test.js View 13 chunks +37 lines, -17 lines 0 comments Download
M extensions/renderer/resources/port.js View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
not at google - send to devlin
5 years, 7 months ago (2015-05-11 20:53:55 UTC) #1
Ken Rockot(use gerrit already)
lgtm
5 years, 7 months ago (2015-05-11 20:57:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135123002/1
5 years, 7 months ago (2015-05-11 21:16:40 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-11 23:04:02 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 23:04:44 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1be1629824f63c62466b44fc90d40101fa9d495a
Cr-Commit-Position: refs/heads/master@{#329265}

Powered by Google App Engine
This is Rietveld 408576698