Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1135113006: Revert of [Sync] Remove periodic sync for Chrome for Android (Closed)

Created:
5 years, 7 months ago by sgurun-gerrit only
Modified:
5 years, 7 months ago
Reviewers:
nyquist, maxbogue
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Sync] Remove periodic sync for Chrome for Android (patchset #2 id:20001 of https://codereview.chromium.org/1148613002/) Reason for revert: seems to break the build https://build.chromium.org/p/chromium/builders/Android/builds/40042 Original issue's description: > [Sync] Remove periodic sync for Chrome for Android > > updateAccount() is always called on startup with the signed in account, > so the removePeriodicSync() call will be hit even for already signed in > users when the app restarts. > > BUG=480688 > > Committed: https://crrev.com/20989a55f294c1b1643cbc2b80bf083de1dd7e36 > Cr-Commit-Position: refs/heads/master@{#330588} TBR=nyquist@chromium.org,maxbogue@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=480688 Committed: https://crrev.com/d98a8607394ca879f251a6be7e721a2b7a0b111c Cr-Commit-Position: refs/heads/master@{#330592}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -42 lines) Patch
M sync/android/java/src/org/chromium/sync/AndroidSyncSettings.java View 2 chunks +0 lines, -4 lines 0 comments Download
M sync/android/java/src/org/chromium/sync/SyncContentResolverDelegate.java View 2 chunks +0 lines, -3 lines 0 comments Download
M sync/android/java/src/org/chromium/sync/SystemSyncContentResolverDelegate.java View 2 chunks +0 lines, -6 lines 0 comments Download
M sync/android/javatests/src/org/chromium/sync/AndroidSyncSettingsTest.java View 4 chunks +0 lines, -24 lines 0 comments Download
M sync/test/android/javatests/src/org/chromium/sync/test/util/MockSyncContentResolverDelegate.java View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sgurun-gerrit only
Created Revert of [Sync] Remove periodic sync for Chrome for Android
5 years, 7 months ago (2015-05-19 20:21:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135113006/1
5 years, 7 months ago (2015-05-19 20:23:11 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 20:25:03 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 20:25:50 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d98a8607394ca879f251a6be7e721a2b7a0b111c
Cr-Commit-Position: refs/heads/master@{#330592}

Powered by Google App Engine
This is Rietveld 408576698