bench/GradientBench.cpp - Issue 1135053002: stop calling SkScalarDiv

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: bench/GradientBench.cpp

Issue 1135053002: stop calling SkScalarDiv (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: fix xpsdevice Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: bench/GradientBench.cpp

diff --git a/bench/GradientBench.cpp b/bench/GradientBench.cpp

index f32c4ef1d269ed7a9b124f8b8479d8163b68c8b1..21b73708d115c056aab09554d04bfc6b10c8c132 100644

--- a/bench/GradientBench.cpp

+++ b/bench/GradientBench.cpp

@@ -101,8 +101,8 @@ static SkShader* MakeConicalZeroRad(const SkPoint pts[2], const GradData& data,

static SkShader* MakeConicalOutside(const SkPoint pts[2], const GradData& data,

SkShader::TileMode tm, float scale) {

SkPoint center0, center1;

- SkScalar radius0 = SkScalarDiv(pts[1].fX - pts[0].fX, 10);

- SkScalar radius1 = SkScalarDiv(pts[1].fX - pts[0].fX, 3);

+ SkScalar radius0 = (pts[1].fX - pts[0].fX) / 10;

+ SkScalar radius1 = (pts[1].fX - pts[0].fX) / 3;

center0.set(pts[0].fX + radius0, pts[0].fY + radius0);

center1.set(pts[1].fX - radius1, pts[1].fY - radius1);

return SkGradientShader::CreateTwoPointConical(center0, radius0,

@@ -115,8 +115,8 @@ static SkShader* MakeConicalOutside(const SkPoint pts[2], const GradData& data,

static SkShader* MakeConicalOutsideZeroRad(const SkPoint pts[2], const GradData& data,