build/common.gypi - Issue 1135023004: Roll Clang 233105-2:236765-2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 1135023004: Roll Clang 233105-2:236765-2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: gn: pass -funique-section-names in release builds only Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index dfa41639f4dd58c069e916f95add33cc176c7abe..fe1b7449d8e36544c00deb4cd1073f88e134376e 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -3797,6 +3797,14 @@

'cflags': ['-fno-unwind-tables', '-fno-asynchronous-unwind-tables'],

'defines': ['NO_UNWIND_TABLES'],

}],

+ ['clang==1', {

+ # Non-unique section names appears to make linker dead stripping

+ # less effective. See http://crbug.com/483026#c20

+ # TODO(hans): Remove this if resolved upstream.

+ 'cflags': [

+ '-funique-section-names',

+ ],

+ }],

« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »