Roll Clang 233105-2:236765-2

build/common.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # IMPORTANT:
 # Please don't directly include this file if you are building via gyp_chromium,
 # since gyp_chromium is automatically forcing its inclusion.
 {
   # Variables expected to be overriden on the GYP command line (-D) or by
   # ~/.gyp/include.gypi.
@@ skipping 3774 matching lines @@
                     ],
                   }],
                 ],
               }],
               ['release_unwind_tables==1', {
                 'cflags': ['-funwind-tables'],
               }, {
                 'cflags': ['-fno-unwind-tables', '-fno-asynchronous-unwind-tables'],
                 'defines': ['NO_UNWIND_TABLES'],
               }],
+              ['clang==1', {
+                # Non-unique section names appears to make linker dead stripping
+                # less effective.

[Nico, 2015/05/14 21:11:09]

Maybe link to the thread or put in a TODO to remove this if the upstream thread
gets resolved with a revert or something

[hans, 2015/05/14 21:25:20]

Done.

+                'cflags': [
+                  '-funique-section-names',
+                ],
+              }],
             ],
           },
         },
         'conditions': [
           ['target_arch=="ia32"', {
             'target_conditions': [
               ['_toolset=="target"', {
                 'asflags': [
                   # Needed so that libs with .s files (e.g. libicudata.a)
                   # are compatible with the general 32-bit-ness.
@@ skipping 2379 matching lines @@
     # settings in target dicts.  SYMROOT is a special case, because many other
     # Xcode variables depend on it, including variables such as
     # PROJECT_DERIVED_FILE_DIR.  When a source group corresponding to something
     # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
     # files to appear (when present) in the UI as actual files and not red
     # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
     # and therefore SYMROOT, needs to be set at the project level.
     'SYMROOT': '<(DEPTH)/xcodebuild',
   },
 }