Source/platform/graphics/filters/FEColorMatrix.h - Issue 1135023003: Rework the checks for too-few values in feColorMatrix filter.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/platform/graphics/filters/FEColorMatrix.h

Issue 1135023003: Rework the checks for too-few values in feColorMatrix filter. (Closed) Base URL: svn://svn.chromium.org/blink/branches/chromium/2357

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/svg/filters/feColorMatrix-setAttribute-crash2-expected.txt ('k') | Source/platform/graphics/filters/FEColorMatrix.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2004, 2005, 2006, 2007 Nikolas Zimmermann <zimmermann@kde.org>	2 * Copyright (C) 2004, 2005, 2006, 2007 Nikolas Zimmermann <zimmermann@kde.org>

3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org>	3 * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org>

4 * Copyright (C) 2005 Eric Seidel <eric@webkit.org>	4 * Copyright (C) 2005 Eric Seidel <eric@webkit.org>

5 * Copyright (C) 2013 Google Inc. All rights reserved.	5 * Copyright (C) 2013 Google Inc. All rights reserved.

6 *	6 *

7 * This library is free software; you can redistribute it and/or	7 * This library is free software; you can redistribute it and/or

8 * modify it under the terms of the GNU Library General Public	8 * modify it under the terms of the GNU Library General Public

9 * License as published by the Free Software Foundation; either	9 * License as published by the Free Software Foundation; either

10 * version 2 of the License, or (at your option) any later version.	10 * version 2 of the License, or (at your option) any later version.

(...skipping 41 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
52	52

53 static inline void calculateSaturateComponents(float* components, float valu e);	53 static inline void calculateSaturateComponents(float* components, float valu e);

54 static inline void calculateHueRotateComponents(float* components, float val ue);	54 static inline void calculateHueRotateComponents(float* components, float val ue);

55	55

56 private:	56 private:

57 FEColorMatrix(Filter*, ColorMatrixType, const Vector<float>&);	57 FEColorMatrix(Filter*, ColorMatrixType, const Vector<float>&);

58	58

59 virtual bool affectsTransparentPixels() override;	59 virtual bool affectsTransparentPixels() override;

60	60

61 ColorMatrixType m_type;	61 ColorMatrixType m_type;

	62

	63 // The m_values vector may not contain the right number of values. Always ch eck

	64 // before accessing contents.

62 Vector<float> m_values;	65 Vector<float> m_values;

63 };	66 };

64	67

65 } // namespace blink	68 } // namespace blink

66	69

67 #endif // FEColorMatrix_h	70 #endif // FEColorMatrix_h

OLD	NEW