Issue 1135013006: Sketch new SkyView interface to the engine

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1135013006: Sketch new SkyView interface to the engine (Closed)

Created:
5 years, 7 months ago by abarth-chromium

Modified:
5 years, 7 months ago

Reviewers:
eseidel

CC:
gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Sketch new SkyView interface to the engine The SkyView interface will replace WebView as the interface to the SkyEngine. The SkyView interface won't have a root level Document or Frame object but instead will implement the base layers of the framework. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9cbfb92f3dde01784fd3feee8ba893f53ec77b7b

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+112 lines, -1 line)			Patch
M	sky/engine/BUILD.gn	View	1 chunk	+2 lines, -1 line	0 comments	Download
A	sky/engine/public/sky/BUILD.gn	View	1 chunk	+23 lines, -0 lines	0 comments	Download
A	sky/engine/public/sky/sky_display_metrics.h	View	1 chunk	+19 lines, -0 lines	0 comments	Download
A	sky/engine/public/sky/sky_view.h	View	1 chunk	+34 lines, -0 lines	0 comments	Download
A	sky/engine/public/sky/sky_view.cc	View	1 chunk	+34 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 7 months ago (2015-05-18 21:48:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9cbfb92f3dde01784fd3feee8ba893f53ec77b7b (presubmit successful).