Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1135013006: Sketch new SkyView interface to the engine (Closed)

Created:
5 years, 7 months ago by abarth-chromium
Modified:
5 years, 7 months ago
Reviewers:
eseidel
CC:
gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Sketch new SkyView interface to the engine The SkyView interface will replace WebView as the interface to the SkyEngine. The SkyView interface won't have a root level Document or Frame object but instead will implement the base layers of the framework. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9cbfb92f3dde01784fd3feee8ba893f53ec77b7b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -1 line) Patch
M sky/engine/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
A sky/engine/public/sky/BUILD.gn View 1 chunk +23 lines, -0 lines 0 comments Download
A sky/engine/public/sky/sky_display_metrics.h View 1 chunk +19 lines, -0 lines 0 comments Download
A sky/engine/public/sky/sky_view.h View 1 chunk +34 lines, -0 lines 0 comments Download
A sky/engine/public/sky/sky_view.cc View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 7 months ago (2015-05-18 21:35:13 UTC) #1
eseidel
lgtm
5 years, 7 months ago (2015-05-18 21:38:23 UTC) #2
abarth-chromium
5 years, 7 months ago (2015-05-18 21:48:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9cbfb92f3dde01784fd3feee8ba893f53ec77b7b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698