Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: chrome/browser/resources/settings/downloads_page/downloads_page.js

Issue 1135013005: Convert the downloads page to Polymer 0.8 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Missed a couple Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'cr-settings-downloads-page' is the settings page containing downloads 7 * 'cr-settings-downloads-page' is the settings page containing downloads
8 * settings. 8 * settings.
9 * 9 *
10 * Example: 10 * Example:
11 * 11 *
12 * <core-animated-pages> 12 * <iron-animated-pages>
13 * <cr-settings-downloads-page prefs="{{prefs}}"> 13 * <cr-settings-downloads-page prefs="{{prefs}}">
14 * </cr-settings-downloads-page> 14 * </cr-settings-downloads-page>
15 * ... other pages ... 15 * ... other pages ...
16 * </core-animated-pages> 16 * </iron-animated-pages>
17 * 17 *
18 * @group Chrome Settings Elements 18 * @group Chrome Settings Elements
19 * @element cr-settings-downloads-page 19 * @element cr-settings-downloads-page
20 */ 20 */
21 Polymer('cr-settings-downloads-page', { 21 Polymer({
22 publish: { 22 is: 'cr-settings-downloads-page',
23
24 properties: {
23 /** 25 /**
24 * Preferences state. 26 * Preferences state.
25 * 27 * @type {?CrSettingsPrefsElement}
26 * @attribute prefs
27 * @type CrSettingsPrefsElement
28 * @default null
29 */ 28 */
30 prefs: null, 29 prefs: {
30 type: Object,
31 notify: true,
32 },
31 33
32 /** 34 /**
33 * Route for the page. 35 * Route for the page.
34 *
35 * @attribute route
36 * @type string
37 * @default ''
38 */ 36 */
39 route: '', 37 route: String,
40 38
41 /** 39 /**
42 * Whether the page is a subpage. 40 * Whether the page is a subpage.
43 *
44 * @attribute subpage
45 * @type boolean
46 * @default false
47 */ 41 */
48 subpage: false, 42 subpage: {
michaelpg 2015/05/12 06:50:19 same as above?
Jeremy Klein 2015/05/12 07:01:15 I kind of like the idea of being explicit with thi
michaelpg 2015/05/12 07:27:47 Either way.
Jeremy Klein 2015/05/12 22:24:17 Went back to add readOnly.
43 type: Boolean,
44 value: false,
45 },
49 46
50 /** 47 /**
51 * ID of the page. 48 * ID of the page.
52 *
53 * @attribute PAGE_ID
54 * @const string
55 * @default 'downloads'
56 */ 49 */
57 PAGE_ID: 'downloads', 50 PAGE_ID: {
51 type: String,
52 value: 'downloads',
53 },
58 54
59 /** 55 /**
60 * Title for the page header and navigation menu. 56 * Title for the page header and navigation menu.
61 *
62 * @attribute pageTitle
63 * @type string
64 */ 57 */
65 pageTitle: loadTimeData.getString('downloadsPageTitle'), 58 pageTitle: {
59 type: String,
60 value: function() {
61 return loadTimeData.getString('downloadsPageTitle');
62 },
63 },
66 64
67 /** 65 /**
68 * Name of the 'core-icon' to show. 66 * Name of the 'iron-icon' to show.
69 *
70 * @attribute icon
71 * @type string
72 * @default 'file-download'
73 */ 67 */
74 icon: 'file-download', 68 icon: {
69 type: String,
70 value: 'file-download',
71 },
75 }, 72 },
76 73
77 selectDownloadLocation: function() { 74 /** @private */
75 selectDownloadLocation_: function() {
78 // TODO(orenb): Communicate with the C++ to actually display a folder 76 // TODO(orenb): Communicate with the C++ to actually display a folder
79 // picker. 77 // picker.
80 this.$.downloadsPath.value = '/Downloads'; 78 this.$.downloadsPath.value = '/Downloads';
81 }, 79 },
82 }); 80 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698