Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 1135003006: Revert of cc: Aggressively expire retro frames. (Closed)

Created:
5 years, 7 months ago by Thiemo Nagel
Modified:
5 years, 7 months ago
Reviewers:
sunnyps, brianderson
CC:
cc-bugs_chromium.org, chromium-reviews, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Aggressively expire retro frames. (patchset #1 id:1 of https://codereview.chromium.org/1055113004/) Reason for revert: This seems to be causing DesktopNativeWidgetNoPaintAfterCloseTest failures. Original issue's description: > cc: Aggressively expire retro frames. > > If we're not aggressive about expiring a retro frame (e.g. MISSED frames) > then it's possible to enter a high latency mode often. > > BUG=469953 > > Committed: https://crrev.com/bb5a390066a1baf27ec44228fd3ba4173f93cfbf > Cr-Commit-Position: refs/heads/master@{#330465} TBR=brianderson@chromium.org,sunnyps@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=469953 Committed: https://crrev.com/7254b49fe3a4d5adaee2ff2db9fc6c2e46b140f5 Cr-Commit-Position: refs/heads/master@{#330504}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -63 lines) Patch
M cc/scheduler/scheduler.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 6 chunks +12 lines, -62 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Thiemo Nagel
Created Revert of cc: Aggressively expire retro frames.
5 years, 7 months ago (2015-05-19 11:36:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135003006/1
5 years, 7 months ago (2015-05-19 11:36:42 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 11:37:16 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7254b49fe3a4d5adaee2ff2db9fc6c2e46b140f5 Cr-Commit-Position: refs/heads/master@{#330504}
5 years, 7 months ago (2015-05-19 11:37:55 UTC) #4
sunnyps
A link to the failing test would be helpful.
5 years, 7 months ago (2015-05-19 18:50:31 UTC) #5
Thiemo Nagel
5 years, 7 months ago (2015-05-20 08:26:08 UTC) #6
Message was sent while issue was closed.
On 2015/05/19 18:50:31, sunnyps wrote:
> A link to the failing test would be helpful.

Hi Sunny,

the failure is at
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/28467.  I
figured that the bot should have already emailed you since you're on the
blamelist for that failure.

Cheers,
Thiemo

Powered by Google App Engine
This is Rietveld 408576698