Source/platform/fonts/Font.cpp - Issue 1135003004: Make small-caps work correctly with tr locale

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/Font.cpp

Issue 1135003004: Make small-caps work correctly with tr locale (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address review comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/fonts/Font.cpp

diff --git a/Source/platform/fonts/Font.cpp b/Source/platform/fonts/Font.cpp

index b00d0a62121b851909603c8ec9766afc4ad20620..b88de99981d3ade1097251b536938d37a6cec794 100644

--- a/Source/platform/fonts/Font.cpp

+++ b/Source/platform/fonts/Font.cpp

@@ -427,7 +427,8 @@ GlyphData Font::glyphDataForCharacter(UChar32& c, bool mirror, bool normalizeSpa

if (variant == AutoVariant) {

if (m_fontDescription.variant() == FontVariantSmallCaps) {

- UChar32 upperC = toUpper(c);

+ bool includeDefault = false;

+ UChar32 upperC = toUpper(c, m_fontDescription.locale(includeDefault).characters8());

tkent 2015/06/02 22:42:19 Why did you add .characters8()? It's wrong.

if (upperC != c) {

c = upperC;

variant = SmallCapsVariant;