Issue 11350: Add back references. Since "back references" is two words...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11350: Add back references. Since "back references" is two words... (Closed)

Created:
12 years, 1 month ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Christian Plesner Hansen

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/regexp2000/

Visibility:
Public.

Description

Add back references. Since "back references" is two words the CamelCasing was fixed in various places. Committed: http://code.google.com/p/v8/source/detail?r=820

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+144 lines, -53 lines)			Patch
M	src/assembler-re2k.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/assembler-re2k.cc	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	src/ast.h	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/ast.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/bytecodes-re2k.h	View	1 chunk	+7 lines, -8 lines	0 comments	Download
M	src/interpreter-re2k.cc	View	1 chunk	+19 lines, -5 lines	0 comments	Download
M	src/jsregexp.h	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	src/jsregexp.cc	View	6 chunks	+26 lines, -7 lines	2 comments	Download
M	src/parser.cc	View	9 chunks	+66 lines, -13 lines	1 comment	Download
M	src/regexp-macro-assembler.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/regexp-macro-assembler-re2k.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/regexp-macro-assembler-re2k.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	test/cctest/test-regexp.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Christian Plesner Hansen

12 years, 1 month ago (2008-11-21 11:16:39 UTC) #2

Stv!

http://codereview.chromium.org/11350/diff/1/12
File src/jsregexp.cc (right):

http://codereview.chromium.org/11350/diff/1/12#newcode1292
Line 1292: ASSERT(start_reg_ + 1 == end_reg_);
ASSERT_EQ

http://codereview.chromium.org/11350/diff/1/12#newcode2224
Line 2224: that->info()->determine_newline =
next->info()->prev_determine_newline();
Propagating this stuff is not the dispatch table constructor's job.

http://codereview.chromium.org/11350/diff/1/13
File src/parser.cc (right):

http://codereview.chromium.org/11350/diff/1/13#newcode555
Line 555: int capture_count_;
This name could be misleading but I can't think of a better one.

Expand Messages | Collapse Messages