ozone: Implement zero/one-copy texture for Ozone GBM.

sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.h"
 
 #include <errno.h>
 #include <fcntl.h>
 #include <fcntl.h>
 #include <linux/net.h>
@@ skipping 17 matching lines @@
 #include "sandbox/linux/bpf_dsl/seccomp_macros.h"
 #include "sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.h"
 #include "sandbox/linux/seccomp-bpf/sandbox_bpf.h"
 #include "sandbox/linux/system_headers/linux_futex.h"
 #include "sandbox/linux/system_headers/linux_syscalls.h"
 #include "sandbox/linux/system_headers/linux_time.h"
 
 // PNaCl toolchain does not provide sys/ioctl.h header.
 #if !defined(OS_NACL_NONSFI)
 #include <sys/ioctl.h>
+#if defined(USE_OZONE)
+#include <drm.h>
+#endif
 #endif
 
 #if defined(OS_ANDROID)
 
 #if !defined(F_DUPFD_CLOEXEC)
 #define F_DUPFD_CLOEXEC (F_LINUX_SPECIFIC_BASE + 6)
 #endif
 
 // https://android.googlesource.com/platform/bionic/+/lollipop-release/libc/private/bionic_prctl.h
 #if !defined(PR_SET_VMA)
@@ skipping 94 matching lines @@
   const Arg<int> option(0);
   return Switch(option)
       .CASES((PR_GET_NAME, PR_SET_NAME, PR_GET_DUMPABLE, PR_SET_DUMPABLE),
              Allow())
 #if defined(OS_ANDROID)
       .CASES((PR_SET_VMA, PR_SET_TIMERSLACK_PID), Allow())
 #endif
       .Default(CrashSIGSYSPrctl());
 }
 
 ResultExpr RestrictIoctl() {

[spang, 2015/07/24 22:08:25]

I think you should split sandbox changes into a separate CL (for now, you can
say test with --no-sandbox in the description).

But anyway, I think as far as whitelisting the 3 ioctls, what you want is:

ResultExpr RestrictIoctl() {
  auto reference_type = TCGETS;
  const Arg<decltype(reference_type)> request(1);
  return Switch(request)
      .CASES(((decltype(reference_type))TCGETS, FIONREAD), Allow())
#if defined(OS_CHROMEOS)
      .CASES(((decltype(reference_type))DRM_IOCTL_GEM_CLOSE,
              DRM_IOCTL_VGEM_MODE_MAP_DUMB, DRM_IOCTL_PRIME_FD_TO_HANDLE),
             Allow())
#endif
      .Default(CrashSIGSYSIoctl());
}

[dshwang, 2015/07/28 15:23:12]

correct. I separate this part into https://codereview.chromium.org/1253363004
following code is needed because TCGETS is 32bit int but DRM_IOCTL_GEM_CLOSE is
64bit int.
cast like "(decltype(reference_type))DRM_IOCTL_GEM_CLOSE" trims upper 32bit and
causes unexpected behavior.

#if defined(OZONE_USE_VGEM_MAP)
  auto reference_type = DRM_IOCTL_GEM_CLOSE;
#else
  auto reference_type = TCGETS;
#endif

-  const Arg<int> request(1);
-  return Switch(request).CASES((TCGETS, FIONREAD), Allow()).Default(
-      CrashSIGSYSIoctl());
+// The type of DRM_IOCTL_XXX macro is long unsigned int.
+#if defined(USE_OZONE)
+  auto reference_type = DRM_IOCTL_MODE_MAP_DUMB;
+#else
+  auto reference_type = TCGETS;
+#endif
+  const Arg<decltype(reference_type)> request(1);
+  return Switch(request)
+      .CASES(((decltype(reference_type))TCGETS, FIONREAD), Allow())
+#if defined(USE_OZONE)
+      .CASES((DRM_IOCTL_MODE_DESTROY_DUMB, DRM_IOCTL_MODE_MAP_DUMB,
+              DRM_IOCTL_PRIME_FD_TO_HANDLE),
+             Allow())
+#endif
+      .Default(CrashSIGSYSIoctl());
 }
 
 ResultExpr RestrictMmapFlags() {
   // The flags you see are actually the allowed ones, and the variable is a
   // "denied" mask because of the negation operator.
   // Significantly, we don't permit MAP_HUGETLB, or the newer flags such as
   // MAP_POPULATE.
   // TODO(davidung), remove MAP_DENYWRITE with updated Tegra libraries.
   const uint64_t kAllowedMask = MAP_SHARED | MAP_PRIVATE | MAP_ANONYMOUS |
                                 MAP_STACK | MAP_NORESERVE | MAP_FIXED |
@@ skipping 144 matching lines @@
                  clockid == CLOCK_MONOTONIC ||
                  clockid == CLOCK_MONOTONIC_COARSE ||
                  clockid == CLOCK_PROCESS_CPUTIME_ID ||
                  clockid == CLOCK_REALTIME ||
                  clockid == CLOCK_REALTIME_COARSE ||
                  clockid == CLOCK_THREAD_CPUTIME_ID,
              Allow()).Else(CrashSIGSYS());
 }
 
 }  // namespace sandbox.