Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Unified Diff: util/thread/thread_posix.cc

Issue 1134943003: Move thread from test/ to util/thread/. (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: PCHECK fix. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « util/thread/thread_log_messages_test.cc ('k') | util/thread/thread_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/thread/thread_posix.cc
diff --git a/test/thread_posix.cc b/util/thread/thread_posix.cc
similarity index 77%
rename from test/thread_posix.cc
rename to util/thread/thread_posix.cc
index 9334d89a3efe52fb7733400efa51f40129fe2c7a..7142c78685c6f2d6d62591a86b558ce04dd158b1 100644
--- a/test/thread_posix.cc
+++ b/util/thread/thread_posix.cc
@@ -12,24 +12,22 @@
// See the License for the specific language governing permissions and
// limitations under the License.
-#include "test/thread.h"
+#include "util/thread/thread.h"
-#include "gtest/gtest.h"
-#include "test/errors.h"
+#include "base/logging.h"
namespace crashpad {
-namespace test {
void Thread::Start() {
- ASSERT_FALSE(platform_thread_);
+ DCHECK(!platform_thread_);
int rv = pthread_create(&platform_thread_, nullptr, ThreadEntryThunk, this);
- ASSERT_EQ(0, rv) << ErrnoMessage(rv, "pthread_create");
+ PCHECK(0 == rv);
}
void Thread::Join() {
- ASSERT_TRUE(platform_thread_);
+ DCHECK(platform_thread_);
int rv = pthread_join(platform_thread_, nullptr);
- EXPECT_EQ(0, rv) << ErrnoMessage(rv, "pthread_join");
+ PCHECK(0 == rv);
platform_thread_ = 0;
}
@@ -40,5 +38,4 @@ void* Thread::ThreadEntryThunk(void* argument) {
return nullptr;
}
-} // namespace test
} // namespace crashpad
« no previous file with comments | « util/thread/thread_log_messages_test.cc ('k') | util/thread/thread_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698