Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Unified Diff: util/thread/thread.h

Issue 1134943003: Move thread from test/ to util/thread/. (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: PCHECK fix. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « util/file/file_io_test.cc ('k') | util/thread/thread.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/thread/thread.h
diff --git a/test/thread.h b/util/thread/thread.h
similarity index 83%
rename from test/thread.h
rename to util/thread/thread.h
index 46fe1e8ebaa1eb0d69a0735313832b6280ce7f14..b1801f83e9b4e0e472844b6ef9835552d26f2b18 100644
--- a/test/thread.h
+++ b/util/thread/thread.h
@@ -12,8 +12,8 @@
// See the License for the specific language governing permissions and
// limitations under the License.
-#ifndef CRASHPAD_TEST_THREAD_H_
-#define CRASHPAD_TEST_THREAD_H_
+#ifndef CRASHPAD_UTIL_THREAD_THREAD_H_
+#define CRASHPAD_UTIL_THREAD_THREAD_H_
#include "base/basictypes.h"
#include "build/build_config.h"
@@ -25,9 +25,8 @@
#endif // OS_POSIX
namespace crashpad {
-namespace test {
-//! \brief Basic thread abstraction for testing. Users should derive from this
+//! \brief Basic thread abstraction. Users should derive from this
//! class and implement ThreadMain().
class Thread {
public:
@@ -43,8 +42,7 @@ class Thread {
void Join();
private:
- //! \brief The entry point to be overridden to implement the test-specific
- //! functionality.
+ //! \brief The thread entry point to be implemented by the subclass.
virtual void ThreadMain() = 0;
static
@@ -64,7 +62,6 @@ class Thread {
DISALLOW_COPY_AND_ASSIGN(Thread);
};
-} // namespace test
} // namespace crashpad
-#endif // CRASHPAD_TEST_THREAD_H_
+#endif // CRASHPAD_UTIL_THREAD_THREAD_H_
« no previous file with comments | « util/file/file_io_test.cc ('k') | util/thread/thread.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698