Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1134933003: Revert of Remove the concept of a cleanup task (Closed)

Created:
5 years, 7 months ago by Dirk Pranke
Modified:
5 years, 7 months ago
CC:
blink-reviews, eae+blinkwatch, falken, blink-reviews-dom_chromium.org, dglazkov+blink, kinuko+worker_chromium.org, horo+watch_chromium.org, rwlbuis, sadrul
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Remove the concept of a cleanup task (patchset #10 id:180001 of https://codereview.chromium.org/1111693003/) Reason for revert: This is also causing flaky failures on the regular Linux ASAN bot: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20ASAN/builds/18485 is the first of multiple failures. I am able to reproduce the failure 100% of the time locally on my linux desktop with this patch; reverting the patch makes the test pass. Sorry! Original issue's description: > Remove the concept of a cleanup task > > The only cleanup task in Blink which is not internal to a worker thread is > the task to close a WebSQL database. Because 1) only worker threads > support the concept of a cleanup task, and 2) WebSQL isn't supported on > worker threads anymore after https://codereview.chromium.org/561093003/, > we can safely remove the logic to handle cleanup tasks on worker > threads. > > BUG=463143 > TBR=jochen@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195191 TBR=kinuko@chromium.org,haraken@chromium.org,alexclarke@chromium.org,jochen@chromium.org,sigbjornf@opera.com,skyostil@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=463143 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195278

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -66 lines) Patch
M Source/core/dom/ExecutionContextTask.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/parser/HTMLParserThread.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/workers/WorkerGlobalScope.cpp View 3 chunks +24 lines, -6 lines 0 comments Download
M Source/core/workers/WorkerThread.h View 3 chunks +4 lines, -6 lines 0 comments Download
M Source/core/workers/WorkerThread.cpp View 10 chunks +67 lines, -36 lines 0 comments Download
M Source/modules/webdatabase/DatabaseThread.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/DatabaseTracker.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/platform/WebThreadSupportingGC.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/WebThreadSupportingGC.cpp View 3 chunks +2 lines, -6 lines 0 comments Download
M public/platform/WebScheduler.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dirk Pranke
Created Revert of Remove the concept of a cleanup task
5 years, 7 months ago (2015-05-12 22:48:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134933003/1
5 years, 7 months ago (2015-05-12 22:49:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=195278
5 years, 7 months ago (2015-05-12 22:49:33 UTC) #3
haraken
5 years, 7 months ago (2015-05-12 23:00:11 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698