Issue 1134913003: Teach SkyView path to draw a circle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1134913003: Teach SkyView path to draw a circle (Closed)

Created:
5 years, 7 months ago by abarth-chromium

Modified:
5 years, 7 months ago

Reviewers:
eseidel

CC:
gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Teach SkyView path to draw a circle This CL adds a global view object that can receive a Picture and be signaled to draw. When using SkyView, this Picture shows up on screen. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0528257be188bcb0b78f974c94fc0ff35414f92f

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+192 lines, -19 lines)			Patch
M	sky/engine/bindings/builtin_sky.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	sky/engine/bindings/builtin_sky.cc	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	sky/engine/bindings/scripts/templates/dart_blink.template	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sky/engine/core/core.gni	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	sky/engine/core/painting/Canvas.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/painting/Picture.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sky/engine/core/script/dart_controller.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	sky/engine/core/script/dart_controller.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
A	sky/engine/core/view/View.h	View	1 chunk	+36 lines, -0 lines	0 comments	Download
A	sky/engine/core/view/View.cpp	View	1 chunk	+29 lines, -0 lines	0 comments	Download
A +	sky/engine/core/view/View.idl	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	sky/engine/public/sky/BUILD.gn	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	sky/engine/public/sky/sky_view.h	View	3 chunks	+12 lines, -2 lines	0 comments	Download
M	sky/engine/public/sky/sky_view.cc	View	3 chunks	+23 lines, -3 lines	0 comments	Download
A	sky/engine/public/sky/sky_view_client.h	View	1 chunk	+20 lines, -0 lines	0 comments	Download
A +	sky/engine/public/sky/sky_view_client.cc	View	1 chunk	+3 lines, -8 lines	0 comments	Download
M	sky/examples/raw/hello_world.dart	View	1 chunk	+20 lines, -1 line	0 comments	Download
M	sky/shell/ui/engine.h	View	3 chunks	+6 lines, -1 line	0 comments	Download
M	sky/shell/ui/engine.cc	View	3 chunks	+12 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

5 years, 7 months ago (2015-05-19 21:20:09 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0528257be188bcb0b78f974c94fc0ff35414f92f (presubmit successful).

Expand Messages | Collapse Messages