Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issue 1134883002: Mojo service implementation for HTTP server - part 1 (Closed)

Created:
5 years, 7 months ago by yzshen1
Modified:
5 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, msw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo service implementation for HTTP server - part 1 This CL adds HTTP server and connection classes, and implements lifespan management for them. The following work will be in future CLs: - convert net::HttpServer::Delegate events about HTTP/WebSocket requests to HttpConnectionDelegate Mojo interface method calls. - tests. BUG=478249 TEST=None Committed: https://crrev.com/eece86a3955d76a86e65e98301a7513a4c9b06fa Cr-Commit-Position: refs/heads/master@{#329461}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+328 lines, -3 lines) Patch
M mojo/services/network/BUILD.gn View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
A mojo/services/network/http_connection_impl.h View 1 2 1 chunk +59 lines, -0 lines 0 comments Download
A mojo/services/network/http_connection_impl.cc View 1 2 1 chunk +73 lines, -0 lines 0 comments Download
A mojo/services/network/http_server_impl.h View 1 2 3 1 chunk +69 lines, -0 lines 0 comments Download
A mojo/services/network/http_server_impl.cc View 1 2 3 1 chunk +119 lines, -0 lines 0 comments Download
M mojo/services/network/network_service_impl.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/network/public/interfaces/http_connection.mojom View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
yzshen1
Hi, John. This CL depends on https://codereview.chromium.org/1136773002/ I pipelined this CL before getting your LG ...
5 years, 7 months ago (2015-05-11 23:47:08 UTC) #2
jam
lgtm with question https://codereview.chromium.org/1134883002/diff/40001/mojo/services/network/http_server_impl.h File mojo/services/network/http_server_impl.h (right): https://codereview.chromium.org/1134883002/diff/40001/mojo/services/network/http_server_impl.h#newcode33 mojo/services/network/http_server_impl.h:33: static HttpServerImpl* Create(HttpServerDelegatePtr delegate); why is ...
5 years, 7 months ago (2015-05-12 15:50:24 UTC) #3
yzshen1
Thanks, John! https://codereview.chromium.org/1134883002/diff/40001/mojo/services/network/http_server_impl.h File mojo/services/network/http_server_impl.h (right): https://codereview.chromium.org/1134883002/diff/40001/mojo/services/network/http_server_impl.h#newcode33 mojo/services/network/http_server_impl.h:33: static HttpServerImpl* Create(HttpServerDelegatePtr delegate); On 2015/05/12 15:50:23, ...
5 years, 7 months ago (2015-05-12 16:02:05 UTC) #4
jam
lgtm
5 years, 7 months ago (2015-05-12 19:26:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134883002/60001
5 years, 7 months ago (2015-05-12 19:36:01 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-12 19:42:00 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 19:42:49 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/eece86a3955d76a86e65e98301a7513a4c9b06fa
Cr-Commit-Position: refs/heads/master@{#329461}

Powered by Google App Engine
This is Rietveld 408576698