dart/sdk/lib/_internal/compiler/implementation/warnings.dart - Issue 11348376: Report errors when factory redirection is used in non-factory methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/warnings.dart

Issue 11348376: Report errors when factory redirection is used in non-factory methods. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Address review comments Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart ('k') | dart/tests/language/language_dart2js.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/sdk/lib/_internal/compiler/implementation/warnings.dart

diff --git a/dart/sdk/lib/_internal/compiler/implementation/warnings.dart b/dart/sdk/lib/_internal/compiler/implementation/warnings.dart

index 3784b290c5418ade27a94e932d24fcf2e6b20dc7..fa8289d7a96e81b83fad1465e639aa9311145565 100644

--- a/dart/sdk/lib/_internal/compiler/implementation/warnings.dart

+++ b/dart/sdk/lib/_internal/compiler/implementation/warnings.dart

@@ -335,6 +335,12 @@ Length: #{3}''');

static const MALFORMED_TYPE_REFERENCE = const MessageKind(

"Malformed type reference encountered in #{1}.");

+ static const FACTORY_REDIRECTION_IN_NON_FACTORY = const MessageKind(

+ "Error: Factory redirection only allowed in factories.");

+ static const MISSING_FACTORY_KEYWORD = const MessageKind(

+ "Did you forget a factory keyword here?");

static const COMPILER_CRASHED = const MessageKind(

"Error: The compiler crashed when compiling this element.");