cc/output_surface_client.h - Issue 11348371: cc: Move WebCompositorOutputSurface and related classes into cc/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/output_surface_client.h

Issue 11348371: cc: Move WebCompositorOutputSurface and related classes into cc/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: mynits Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright 2012 The Chromium Authors. All rights reserved.
	jamesr 2012/12/04 07:06:51 leading space here for some reason leading space here for some reason
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CC_OUTPUT_SURFACE_CLIENT_H_

	6 #define CC_OUTPUT_SURFACE_CLIENT_H_

	7

	8 namespace cc {

	9

	10 class CompositorFrameAck;

	11

	12 class OutputSurfaceClient {

	13 public:

	14 virtual void OnVSyncParametersChanged(double monotonicTimebase, double interva lInSeconds) = 0;
	jamesr 2012/12/04 07:06:51 the types on this should be base::TimeTicks and ba the types on this should be base::TimeTicks and base::TimeDelta. they're only double in WebKit because it doesn't have proper time types 80col danakj 2012/12/04 18:15:34 Done. Show quoted text On 2012/12/04 07:06:51, jamesr wrote: > the types on this should be base::TimeTicks and base::TimeDelta. they're only > double in WebKit because it doesn't have proper time types > > 80col Done.
	15 virtual void OnSendFrameToParentCompositorAck(const CompositorFrameAck&) {}
	jamesr 2012/12/04 07:06:51 do we need a default impl of this or can it be pur do we need a default impl of this or can it be pure virtual? it's useful to have default impls on logically pure virtual interfaces in WebKit API since it's annoying to update impls at the same time, but since this is all chromium you should be able to find + update all OutputSurfaceClient implementations danakj 2012/12/04 18:15:34 Sure, I'll have to add the method to LayerTreeHost Show quoted text On 2012/12/04 07:06:51, jamesr wrote: > do we need a default impl of this or can it be pure virtual? it's useful to have > default impls on logically pure virtual interfaces in WebKit API since it's > annoying to update impls at the same time, but since this is all chromium you > should be able to find + update all OutputSurfaceClient implementations Sure, I'll have to add the method to LayerTreeHost now then.
	16 };
	jamesr 2012/12/04 07:06:51 can you add an empty virtual dtor (probably protec can you add an empty virtual dtor (probably protected) ? danakj 2012/12/04 18:15:34 Done. Show quoted text On 2012/12/04 07:06:51, jamesr wrote: > can you add an empty virtual dtor (probably protected) ? Done.
	17

	18 } // namespace cc

	19

	20 #endif // CC_OUTPUT_SURFACE_CLIENT_H_

OLD	NEW

« cc/output_surface.h ('K') | « cc/output_surface.h ('k') | cc/proxy.h » ('j') | cc/software_output_device.h » ('J')