Index: chrome/browser/prerender/prerender_tracker.cc |
diff --git a/chrome/browser/prerender/prerender_tracker.cc b/chrome/browser/prerender/prerender_tracker.cc |
index bcd95e69993d9079d90278e15d1daba87739aba8..5392ca6a54091eb65da97e08fc343a79769ac982 100644 |
--- a/chrome/browser/prerender/prerender_tracker.cc |
+++ b/chrome/browser/prerender/prerender_tracker.cc |
@@ -48,14 +48,26 @@ struct RenderViewInfo { |
}; |
PrerenderTracker::PrerenderTracker() { |
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); |
} |
PrerenderTracker::~PrerenderTracker() { |
+ for (std::set<PrerenderContents*>::iterator it = observing_set_.begin(); |
+ it != observing_set_.end(); ++it) { |
+ (*it)->RemoveObserver(this); |
+ } |
mmenke
2012/12/03 20:02:47
Isn't the PrerenderTracker shut down after the las
gavinp
2012/12/04 18:04:48
Done.
|
+} |
+ |
+void PrerenderTracker::AddPrerenderContents( |
+ PrerenderContents* prerender_contents) { |
+ DCHECK(CalledOnValidThread()); |
+ prerender_contents->AddObserver(this); |
+ observing_set_.insert(prerender_contents); |
} |
-bool PrerenderTracker::TryUse(int child_id, int route_id) { |
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); |
mmenke
2012/12/03 20:02:47
nit: Extra line break not needed.
gavinp
2012/12/04 18:04:48
Done.
|
+bool PrerenderTracker::TryUse(int child_id, int route_id) { |
+ DCHECK(CalledOnValidThread()); |
return SetFinalStatus(child_id, route_id, FINAL_STATUS_USED, NULL); |
} |
@@ -77,7 +89,8 @@ bool PrerenderTracker::TryCancelOnIOThread( |
int route_id, |
FinalStatus final_status) { |
DCHECK_NE(FINAL_STATUS_USED, final_status); |
- DCHECK(final_status >= 0 && final_status < FINAL_STATUS_MAX); |
+ DCHECK_LE(0, final_status); |
+ DCHECK_GT(FINAL_STATUS_MAX, final_status); |
if (!IsPrerenderingOnIOThread(child_id, route_id)) |
return false; |
@@ -91,23 +104,26 @@ bool PrerenderTracker::GetFinalStatus(int child_id, int route_id, |
base::AutoLock lock(final_status_map_lock_); |
FinalStatusMap::const_iterator final_status_it = |
final_status_map_.find(child_route_id_pair); |
- if (final_status_map_.end() == final_status_map_.find(child_route_id_pair)) |
+ if (final_status_map_.count(child_route_id_pair) == 0) |
return false; |
*final_status = final_status_it->second.final_status; |
return true; |
} |
-void PrerenderTracker::OnPrerenderingStarted( |
- int child_id, int route_id, PrerenderManager* prerender_manager) { |
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); |
- DCHECK_GE(child_id, 0); |
- DCHECK_GE(route_id, 0); |
+void PrerenderTracker::OnPrerenderStart( |
+ PrerenderContents* prerender_contents) { |
+ DCHECK(CalledOnValidThread()); |
+ int child_id; |
+ if (!prerender_contents->GetChildId(&child_id)) |
+ return; |
+ int route_id; |
+ if (!prerender_contents->GetRouteId(&route_id)) |
+ return; |
mmenke
2012/12/03 20:02:47
nit: May be a little prettier if these if stateme
gavinp
2012/12/04 18:04:48
I'm going to go ahead and ignore this nit from thi
|
ChildRouteIdPair child_route_id_pair(child_id, route_id); |
// The RenderView should not already be prerendering. |
- DCHECK(final_status_map_.end() == |
- final_status_map_.find(child_route_id_pair)); |
+ DCHECK_EQ(0u, final_status_map_.count(child_route_id_pair)); |
BrowserThread::PostTask( |
BrowserThread::IO, FROM_HERE, |
@@ -116,13 +132,21 @@ void PrerenderTracker::OnPrerenderingStarted( |
base::AutoLock lock(final_status_map_lock_); |
final_status_map_.insert( |
- std::make_pair(child_route_id_pair, RenderViewInfo(prerender_manager))); |
+ std::make_pair(child_route_id_pair, |
+ RenderViewInfo(prerender_contents->prerender_manager()))); |
} |
-void PrerenderTracker::OnPrerenderingFinished(int child_id, int route_id) { |
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); |
- DCHECK_GE(child_id, 0); |
- DCHECK_GE(route_id, 0); |
+void PrerenderTracker::OnPrerenderStop( |
+ PrerenderContents* prerender_contents) { |
+ DCHECK(CalledOnValidThread()); |
+ prerender_contents->RemoveObserver(this); |
mmenke
2012/12/03 20:02:47
Wonder if we should just clear the observer list i
gavinp
2012/12/04 18:04:48
That's a great idea; it avoids a ton of crashes.
|
+ observing_set_.erase(prerender_contents); |
mmenke
2012/12/03 20:02:47
Suggest a DCHECK_EQ(1, observer_set_.count(prerend
gavinp
2012/12/04 18:04:48
Done. This turned out to require a significant rew
|
+ int child_id; |
+ if (!prerender_contents->GetChildId(&child_id)) |
+ return; |
+ int route_id; |
+ if (!prerender_contents->GetRouteId(&route_id)) |
+ return; |
mmenke
2012/12/03 20:02:47
nit: May be a little prettier if these if stateme
|
ChildRouteIdPair child_route_id_pair(child_id, route_id); |
@@ -178,8 +202,7 @@ bool PrerenderTracker::IsPrerenderingOnIOThread(int child_id, |
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO)); |
ChildRouteIdPair child_route_id_pair(child_id, route_id); |
- return possibly_prerendering_io_thread_set_.end() != |
- possibly_prerendering_io_thread_set_.find(child_route_id_pair); |
+ return possibly_prerendering_io_thread_set_.count(child_route_id_pair) > 0; |
} |
void PrerenderTracker::AddPrerenderOnIOThread( |