Issue 11348347: Link in proper TLS accessor implementation into untusted ARM IRT.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11348347: Link in proper TLS accessor implementation into untusted ARM IRT. (Closed)

Created:
8 years ago by Nike

Modified:
8 years ago

Reviewers:
dmichael (off chromium), Mark Seaborn

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

NaCl: Link proper TLS accessor implementation into untrusted ARM IRT. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3174 TEST=along with IRT init and va_list fixes allows to run ARM nexes Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170959

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added comment #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	ppapi/native_client/native_client.gyp	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dmichael (off chromium)

I'll trust Mark to review this; the gyp looks fine, but I know nothing about ...

8 years ago (2012-12-03 15:44:42 UTC) #1

Mark Seaborn

LGTM with the change below, and please run an ARM try job before committing. The ...

8 years ago (2012-12-03 16:10:51 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/olonho@chromium.org/11348347/7001

8 years ago (2012-12-04 10:50:12 UTC) #3

Message was sent while issue was closed.

Change committed as 170959

Expand Messages | Collapse Messages