Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5731)

Unified Diff: chrome/browser/extensions/api/tabs/tabs.cc

Issue 11348344: Remove last usages of FindTabbedBrowserDeprecated. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove presubmit check as well. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/tabs/tabs.cc
diff --git a/chrome/browser/extensions/api/tabs/tabs.cc b/chrome/browser/extensions/api/tabs/tabs.cc
index 3b92c40d88a7e4064c0ee1f98ab691518398e886..84bef2abca3695660b9a5fdfe20851e08a6df404 100644
--- a/chrome/browser/extensions/api/tabs/tabs.cc
+++ b/chrome/browser/extensions/api/tabs/tabs.cc
@@ -997,8 +997,8 @@ bool CreateTabFunction::RunImpl() {
// Ensure the selected browser is tabbed.
grt (UTC plus 2) 2012/12/03 15:54:39 i haven't studied when this is called, but since |
robertshield 2012/12/03 20:25:58 You're right, I had missed that this call site wou
if (!browser->is_type_tabbed() && browser->IsAttemptingToCloseBrowser())
- browser = browser::FindTabbedBrowserDeprecated(profile(),
- include_incognito());
+ browser = browser::FindTabbedBrowser(profile(), include_incognito(),
+ chrome::GetActiveDesktop());
if (!browser || !browser->window())
return false;
@@ -1064,7 +1064,8 @@ bool CreateTabFunction::RunImpl() {
!GetExtension()->incognito_split_mode() &&
browser->profile()->IsOffTheRecord()) {
Profile* profile = browser->profile()->GetOriginalProfile();
- browser = browser::FindTabbedBrowserDeprecated(profile, false);
+ browser = browser::FindTabbedBrowser(profile, false,
+ chrome::GetActiveDesktop());
grt (UTC plus 2) 2012/12/03 15:54:39 along similar lines, why not use the same host des
robertshield 2012/12/03 20:25:58 Done.
if (!browser) {
browser = new Browser(Browser::CreateParams(profile));
grt (UTC plus 2) 2012/12/03 15:54:39 specify the same host desktop type here as that us
robertshield 2012/12/03 20:25:58 Done.
browser->window()->Show();

Powered by Google App Engine
This is Rietveld 408576698