Remove last usages of FindTabbedBrowserDeprecated.

chrome/browser/extensions/extension_install_ui_default.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_install_ui_default.h"
 
 #include "base/command_line.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/api/infobars/confirm_infobar_delegate.h"
 #include "chrome/browser/extensions/extension_install_prompt.h"
@@ skipping 166 matching lines @@
 }
 
 // static
 void ExtensionInstallUIDefault::ShowThemeInfoBar(
     const std::string& previous_theme_id, bool previous_using_native_theme,
     const Extension* new_theme, Profile* profile) {
   if (!new_theme->is_theme())
     return;
 
   // Get last active tabbed browser of profile.
-  Browser* browser = browser::FindTabbedBrowserDeprecated(profile, true);
+  Browser* browser = browser::FindTabbedBrowser(profile,
+                                                true,
+                                                chrome::GetActiveDesktop());

[grt (UTC plus 2), 2012/12/03 15:54:39]

if the user clicked on a link on the web store and then switched desktops,
should the infobar appear in the originating desktop? is it possible to know the
context at the time that the theme (extension) was installed?

[robertshield, 2012/12/03 20:25:58]

Sometimes. This is called from OnInstallSuccess, which is called in two places.
One of these places is CrxInstaller which is used in a couple of different
places, only some of which have context.

The main place that doesn't have context is in ChromeDownloadManagerDelegate
which is where my search stopped when I made this change. 

The best way to do this is probably to plumb context through the downloads
system so I could revert this line change and do that first. What say you?

   if (!browser)
     return;
 
   WebContents* web_contents = chrome::GetActiveWebContents(browser);
   if (!web_contents)
     return;
   InfoBarTabHelper* infobar_helper =
       InfoBarTabHelper::FromWebContents(web_contents);
 
   // First find any previous theme preview infobars.
@@ skipping 84 matching lines @@
   return new ExtensionInstallPrompt(web_contents);
 }
 
 // static
 ExtensionInstallPrompt* ExtensionInstallUI::CreateInstallPromptWithProfile(
     Profile* profile) {
   Browser* browser = chrome::FindLastActiveWithProfile(profile,
       chrome::GetActiveDesktop());
   return CreateInstallPromptWithBrowser(browser);
 }