Issue 11348342: Revert 170590

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11348342: Revert 170590 (Closed)

Created:
8 years ago by dmazzoni

Modified:
8 years ago

Reviewers:
dmazzoni

CC:
chromium-reviews, oshima+watch_chromium.org, nkostylev+watch_chromium.org, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, jam, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, ctguil+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, zork+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 170590 It looks like the call to GetMagnifierType() on accessibility_util:124 is introducing some crashes. chrome!chromeos::accessibility::GetMagnifierType() [accessibility_util.cc : 283 + 0xb > Add Chrome OS accessibility histograms. > > BUG=99504 > TBR=joi > > Review URL: https://chromiumcodereview.appspot.com/11414232 TBR=dmazzoni@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170698

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -57 lines)			Patch
M	chrome/browser/chromeos/accessibility/accessibility_util.h	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/accessibility/accessibility_util.cc	View	4 chunks	+0 lines, -29 lines	0 comments	Download
M	chrome/browser/chromeos/chrome_browser_main_chromeos.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	content/browser/accessibility/browser_accessibility_state_impl.h	View	3 chunks	+0 lines, -5 lines	0 comments	Download
M	content/browser/accessibility/browser_accessibility_state_impl.cc	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	content/public/browser/browser_accessibility_state.h	View	2 chunks	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages