Move MTPDeviceDelegateImplLinux worker classes to its own files.

Move MTPDeviceDelegateImplLinux worker classes to its own files.

BUG=none
TEST=none


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171027

[Lei Zhang, 2012-12-03 22:23:53]

Let's pretend we have another separate protocol, say, XYZP. Would you prefer to
see:

a)
open_mtp_storage_worker.h
open_xyzp_storage_worker.h
read_mtp_storage_worker.h
read_xyzp_storage_worker.h

or

b)

mtp_open_storage_worker.h
mtp_read_storage_worker.h
xyzp_open_storage_worker.h
xyzp_read_storage_worker.h

?

https://codereview.chromium.org/11348337/diff/1041/chrome/browser/media_galle...
File chrome/browser/media_gallery/linux/mtp_device_delegate_impl_linux.cc
(right):

https://codereview.chromium.org/11348337/diff/1041/chrome/browser/media_galle...
chrome/browser/media_gallery/linux/mtp_device_delegate_impl_linux.cc:1: //
Copyright (c) 2012 The Chromium Authors. All rights reserved.
Can you tweak the git similarity parameter so this shows up as a rename and not
a new file?

https://codereview.chromium.org/11348337/diff/1041/chrome/browser/media_galle...
File chrome/browser/media_gallery/linux/read_mtp_directory_worker.h (right):

https://codereview.chromium.org/11348337/diff/1041/chrome/browser/media_galle...
chrome/browser/media_gallery/linux/read_mtp_directory_worker.h:44:
ReadMTPDirectoryWorker(const std::string& storage_name,
Are you using this ctor anywhere? If not, let's get rid of it.

https://codereview.chromium.org/11348337/diff/1041/chrome/browser/media_galle...
File chrome/browser/media_gallery/linux/read_mtp_file_worker.cc (right):

https://codereview.chromium.org/11348337/diff/1041/chrome/browser/media_galle...
chrome/browser/media_gallery/linux/read_mtp_file_worker.cc:100: error_occurred_
= (error || (data.size() != BytesToRead()));
nit: don't go overboard with parenthesis.

[kmadhusu, 2012-12-03 23:30:00]

I preferred (b). Fixed all the file/class names. PTAL.

Thanks.

https://codereview.chromium.org/11348337/diff/1041/chrome/browser/media_galle...
File chrome/browser/media_gallery/linux/mtp_device_delegate_impl_linux.cc
(right):

https://codereview.chromium.org/11348337/diff/1041/chrome/browser/media_galle...
chrome/browser/media_gallery/linux/mtp_device_delegate_impl_linux.cc:1: //
Copyright (c) 2012 The Chromium Authors. All rights reserved.
On 2012/12/03 22:23:54, Lei Zhang wrote:
> Can you tweak the git similarity parameter so this shows up as a rename and
not
> a new file?

I tried with different similiarity(e.g 60, 80, 75, 100) values. I didn't get a
pretty diff for any of them.

https://codereview.chromium.org/11348337/diff/1041/chrome/browser/media_galle...
File chrome/browser/media_gallery/linux/read_mtp_directory_worker.h (right):

https://codereview.chromium.org/11348337/diff/1041/chrome/browser/media_galle...
chrome/browser/media_gallery/linux/read_mtp_directory_worker.h:44:
ReadMTPDirectoryWorker(const std::string& storage_name,
On 2012/12/03 22:23:54, Lei Zhang wrote:
> Are you using this ctor anywhere? If not, let's get rid of it.

Yes in RecursiveMTPDeviceObjectEnumerator::Next().

[Lei Zhang, 2012-12-03 23:46:27]

lgtm

https://codereview.chromium.org/11348337/diff/1041/chrome/browser/media_galle...
File chrome/browser/media_gallery/linux/mtp_device_delegate_impl_linux.cc
(right):

https://codereview.chromium.org/11348337/diff/1041/chrome/browser/media_galle...
chrome/browser/media_gallery/linux/mtp_device_delegate_impl_linux.cc:1: //
Copyright (c) 2012 The Chromium Authors. All rights reserved.
On 2012/12/03 23:30:00, kmadhusu wrote:
> On 2012/12/03 22:23:54, Lei Zhang wrote:
> > Can you tweak the git similarity parameter so this shows up as a rename and
> not
> > a new file?
> 
> I tried with different similiarity(e.g 60, 80, 75, 100) values. I didn't get a
> pretty diff for any of them.

Aww, too bad. It would be nice to preserve the history of the file.

[commit-bot: I haz the power, 2012-12-03 23:49:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/11348337/3014

[commit-bot: I haz the power, 2012-12-04 03:30:45]

Retried try job too often on mac_rel for step(s) browser_tests

[commit-bot: I haz the power, 2012-12-04 17:39:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/11348337/3014

[commit-bot: I haz the power, 2012-12-04 19:43:31]

Change committed as 171027