Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Unified Diff: net/spdy/spdy_test_util_spdy2.cc

Issue 11348333: Clean up SpdySessionDependencies to remove code duplication. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Cleanup Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_test_util_spdy2.cc
diff --git a/net/spdy/spdy_test_util_spdy2.cc b/net/spdy/spdy_test_util_spdy2.cc
index 476d73c6c0775106cb366ba137cf03df1543643c..be6f8dcb7e3b2b420c8724bc969a9aa307cecfe0 100644
--- a/net/spdy/spdy_test_util_spdy2.cc
+++ b/net/spdy/spdy_test_util_spdy2.cc
@@ -905,7 +905,8 @@ SpdySessionDependencies::SpdySessionDependencies()
socket_factory(new MockClientSocketFactory),
deterministic_socket_factory(new DeterministicMockClientSocketFactory),
http_auth_handler_factory(
- HttpAuthHandlerFactory::CreateDefault(host_resolver.get())) {
+ HttpAuthHandlerFactory::CreateDefault(host_resolver.get())),
+ net_log(NULL) {
// Note: The CancelledTransaction test does cleanup by running all
// tasks in the message loop (RunAllPending). Unfortunately, that
// doesn't clean up tasks on the host resolver thread; and
@@ -923,24 +924,16 @@ SpdySessionDependencies::SpdySessionDependencies(ProxyService* proxy_service)
socket_factory(new MockClientSocketFactory),
deterministic_socket_factory(new DeterministicMockClientSocketFactory),
http_auth_handler_factory(
- HttpAuthHandlerFactory::CreateDefault(host_resolver.get())) {}
+ HttpAuthHandlerFactory::CreateDefault(host_resolver.get())),
+ net_log(NULL) {}
SpdySessionDependencies::~SpdySessionDependencies() {}
// static
HttpNetworkSession* SpdySessionDependencies::SpdyCreateSession(
SpdySessionDependencies* session_deps) {
- net::HttpNetworkSession::Params params;
+ net::HttpNetworkSession::Params params = session_deps->CreateSessionParams();
params.client_socket_factory = session_deps->socket_factory.get();
- params.host_resolver = session_deps->host_resolver.get();
- params.cert_verifier = session_deps->cert_verifier.get();
- params.proxy_service = session_deps->proxy_service.get();
- params.ssl_config_service = session_deps->ssl_config_service;
- params.http_auth_handler_factory =
- session_deps->http_auth_handler_factory.get();
- params.http_server_properties = &session_deps->http_server_properties;
- params.trusted_spdy_proxy =
- session_deps->trusted_spdy_proxy;
HttpNetworkSession* http_session = new HttpNetworkSession(params);
SpdySessionPoolPeer pool_peer(http_session->spdy_session_pool());
pool_peer.EnableSendingInitialSettings(false);
@@ -950,22 +943,28 @@ HttpNetworkSession* SpdySessionDependencies::SpdyCreateSession(
// static
HttpNetworkSession* SpdySessionDependencies::SpdyCreateSessionDeterministic(
SpdySessionDependencies* session_deps) {
- net::HttpNetworkSession::Params params;
+ net::HttpNetworkSession::Params params = session_deps->CreateSessionParams();
params.client_socket_factory =
session_deps->deterministic_socket_factory.get();
- params.host_resolver = session_deps->host_resolver.get();
- params.cert_verifier = session_deps->cert_verifier.get();
- params.proxy_service = session_deps->proxy_service.get();
- params.ssl_config_service = session_deps->ssl_config_service;
- params.http_auth_handler_factory =
- session_deps->http_auth_handler_factory.get();
- params.http_server_properties = &session_deps->http_server_properties;
HttpNetworkSession* http_session = new HttpNetworkSession(params);
SpdySessionPoolPeer pool_peer(http_session->spdy_session_pool());
pool_peer.EnableSendingInitialSettings(false);
return http_session;
}
+net::HttpNetworkSession::Params SpdySessionDependencies::CreateSessionParams() {
+ net::HttpNetworkSession::Params params;
+ params.host_resolver = host_resolver.get();
+ params.cert_verifier = cert_verifier.get();
+ params.proxy_service = proxy_service.get();
+ params.ssl_config_service = ssl_config_service;
+ params.http_auth_handler_factory = http_auth_handler_factory.get();
+ params.http_server_properties = &http_server_properties;
+ params.trusted_spdy_proxy = trusted_spdy_proxy;
+ params.net_log = net_log;
+ return params;
+}
+
SpdyURLRequestContext::SpdyURLRequestContext()
: ALLOW_THIS_IN_INITIALIZER_LIST(storage_(this)) {
storage_.set_host_resolver(scoped_ptr<HostResolver>(new MockHostResolver));

Powered by Google App Engine
This is Rietveld 408576698