Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/bailout.dart

Issue 11348316: Move the handling of operator[] into the new interceptors. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/ssa/bailout.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/bailout.dart (revision 15541)
+++ sdk/lib/_internal/compiler/implementation/ssa/bailout.dart (working copy)
@@ -146,9 +146,11 @@
// inserted for this method. The code size price for an additional
// type guard is much smaller than the first one that causes the
// generation of a bailout method.
- if (instruction is HIndex &&
- (instruction as HIndex).isBuiltin(types) &&
- hasTypeGuards) {
+ var temp = instruction;
kasperl 2012/11/30 09:23:04 How about factoring this condition out into a sepa
ngeoffray 2012/11/30 13:18:14 Done.
+ if ((temp is HIndex
+ || (temp is HInvokeDynamicMethod
+ && temp.isIndexOperatorOnIndexablePrimitive(types)))
+ && hasTypeGuards) {
HBasicBlock loopHeader = instruction.block.enclosingLoopHeader;
if (loopHeader != null && loopHeader.parentLoopHeader != null) {
return true;

Powered by Google App Engine
This is Rietveld 408576698