Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 11348314: FocusController needs to restack windows upon activation (but not focus). (Closed)

Created:
8 years ago by Ben Goodger (Google)
Modified:
8 years ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

FocusController needs to restack windows upon activation (but not focus). This uncovered an old bug in Window - if the removal results in a restack, the iterator is invalid. Fortunately we can just defer the iterator creation until after the notification. With the restacking one activation test expecation also changes. http://crbug.com/162100 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170478

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -3 lines) Patch
M ui/aura/window.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/corewm/focus_controller.cc View 1 2 5 chunks +23 lines, -0 lines 0 comments Download
M ui/views/corewm/focus_controller_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Ben Goodger (Google)
8 years ago (2012-11-30 04:26:53 UTC) #1
Ben Goodger (Google)
Redirecting to sadrul since I think sky may be out today.
8 years ago (2012-11-30 16:46:04 UTC) #2
sadrul
8 years ago (2012-11-30 16:59:00 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698