Force-load a lazy background page whenever an extension is enabled.

chrome/browser/extensions/extension_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_service.h"
 
 #include <algorithm>
 #include <set>
 
 #include "base/basictypes.h"
@@ skipping 171 matching lines @@
 const char* kNaClPluginMimeType = "application/x-nacl";
 
 static bool IsSyncableExtension(const Extension& extension) {
   return extension.GetSyncType() == Extension::SYNC_TYPE_EXTENSION;
 }
 
 static bool IsSyncableApp(const Extension& extension) {
   return extension.GetSyncType() == Extension::SYNC_TYPE_APP;
 }
 
+static void DoNothing(extensions::ExtensionHost* host) {
+}
+
 }  // namespace
 
 ExtensionService::ExtensionRuntimeData::ExtensionRuntimeData()
     : background_page_ready(false),
       being_upgraded(false),
       has_used_webrequest(false) {
 }
 
 ExtensionService::ExtensionRuntimeData::~ExtensionRuntimeData() {
 }
@@ skipping 726 matching lines @@
     AcknowledgeExternalExtension(extension->id());
   }
 
   if (disable_reasons & Extension::DISABLE_SIDELOAD_WIPEOUT)
     UMA_HISTOGRAM_BOOLEAN("DisabledExtension.ExtensionWipedStatus", false);
 
   // Move it over to the enabled list.
   extensions_.Insert(make_scoped_refptr(extension));
   disabled_extensions_.Remove(extension->id());
 
+  // If the extension has a lazy background page, make sure it gets loaded to

[Matt Perry, 2012/11/29 20:24:46]

ExtensionService is not the best place for this code. Better to have a system
listen to NOTIFICATION_EXTENSION_ENABLED and do it there. EventRouter seems like
the best fit.

[Marijn Kruisselbrink, 2012/11/29 21:07:19]

Ah yes, of course. Done.

+  // discover which events the extension wants to listen to.
+  if (extension->has_lazy_background_page()) {
+    extensions::LazyBackgroundTaskQueue* queue =
+        system_->lazy_background_task_queue();
+    queue->AddPendingTask(profile_, extension->id(), base::Bind(&DoNothing));
+  }
+
   NotifyExtensionLoaded(extension);
 
   // Notify listeners that the extension was enabled.
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_EXTENSION_ENABLED,
       content::Source<Profile>(profile_),
       content::Details<const Extension>(extension));
 
   SyncExtensionChangeIfNeeded(*extension);
 }
@@ skipping 2035 matching lines @@
         extension_id, kOnUpdateAvailableEvent);
   } else {
     // Delay installation if the extension is not idle.
     return !IsExtensionIdle(extension_id);
   }
 }
 
 void ExtensionService::OnBlacklistUpdated() {
   CheckManagementPolicy();
 }