[autofill] Fill in values on a successful run of interactive autocomplete.

chrome/renderer/autofill/autofill_agent.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/autofill/autofill_agent.h"
 
 #include "base/bind.h"
 #include "base/message_loop.h"
 #include "base/string_util.h"
 #include "base/string_split.h"
@@ skipping 140 matching lines @@
     IPC_MESSAGE_HANDLER(AutofillMsg_SetAutofillActionPreview,
                         OnSetAutofillActionPreview)
     IPC_MESSAGE_HANDLER(AutofillMsg_ClearPreviewedForm,
                         OnClearPreviewedForm)
     IPC_MESSAGE_HANDLER(AutofillMsg_SetNodeText,
                         OnSetNodeText)
     IPC_MESSAGE_HANDLER(AutofillMsg_AcceptDataListSuggestion,
                         OnAcceptDataListSuggestion)
     IPC_MESSAGE_HANDLER(AutofillMsg_AcceptPasswordAutofillSuggestion,
                         OnAcceptPasswordAutofillSuggestion)
-    IPC_MESSAGE_HANDLER(AutofillMsg_RequestAutocompleteFinished,
-                        OnRequestAutocompleteFinished)
+    IPC_MESSAGE_HANDLER(AutofillMsg_RequestAutocompleteSuccess,
+                        OnRequestAutocompleteSuccess)
+    IPC_MESSAGE_HANDLER(AutofillMsg_RequestAutocompleteError,
+                        OnRequestAutocompleteError)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
 void AutofillAgent::DidFinishDocumentLoad(WebFrame* frame) {
   // The document has now been fully loaded.  Scan for forms to be sent up to
   // the browser.
   std::vector<FormData> forms;
   form_cache_.ExtractForms(*frame, &forms);
@@ skipping 151 matching lines @@
 }
 
 void AutofillAgent::textFieldDidEndEditing(const WebInputElement& element) {
   password_autofill_manager_->TextFieldDidEndEditing(element);
   has_shown_autofill_popup_for_current_edit_ = false;
   Send(new AutofillHostMsg_DidEndTextFieldEditing(routing_id()));
 }
 
 void AutofillAgent::textFieldDidChange(const WebInputElement& element) {
   if (did_set_node_text_) {
-      did_set_node_text_ = false;
-      return;
+    did_set_node_text_ = false;
+    return;
   }
 
   // We post a task for doing the Autofill as the caret position is not set
   // properly at this point (http://bugs.webkit.org/show_bug.cgi?id=16976) and
   // it is needed to trigger autofill.
   weak_ptr_factory_.InvalidateWeakPtrs();
   MessageLoop::current()->PostTask(
         FROM_HERE,
         base::Bind(&AutofillAgent::TextFieldDidChangeImpl,
                    weak_ptr_factory_.GetWeakPtr(), element));
@@ skipping 236 matching lines @@
 void AutofillAgent::OnAcceptPasswordAutofillSuggestion(const string16& value) {
   // We need to make sure this is handled here because the browser process
   // skipped it handling because it believed it would be handled here. If it
   // isn't handled here then the browser logic needs to be updated.
   bool handled = password_autofill_manager_->DidAcceptAutofillSuggestion(
       element_,
       value);
   DCHECK(handled);
 }
 
-void AutofillAgent::OnRequestAutocompleteFinished(
-    WebFormElement::AutocompleteResult result) {
+void AutofillAgent::OnRequestAutocompleteSuccess(const FormData& form_data) {
   DCHECK(!in_flight_request_form_.isNull());
 
-  in_flight_request_form_.finishRequestAutocomplete(result);
+  std::vector<WebKit::WebFormControlElement> elements;
+  autofill::ExtractAutofillableElements(in_flight_request_form_,
+                                        REQUIRE_AUTOCOMPLETE,
+                                        &elements);
+
+  for (size_t i = 0; i < form_data.fields.size(); ++i) {
+    const FormFieldData field = form_data.fields[i];
+
+    // TODO(dbeam): change to DCHECK() if values must be non-empty to confirm.
+    if (field.value.empty())
+      continue;
+
+    const std::string field_attr_lower =
+        StringToLowerASCII(field.autocomplete_attribute);
+    for (size_t j = 0; j < elements.size(); ++j) {
+      WebInputElement element = elements[j].to<WebInputElement>();
+      std::string element_attr =
+          UTF16ToASCII(element.getAttribute("autocomplete"));
+      if (field_attr_lower == StringToLowerASCII(element_attr)) {
+        element.setValue(field.value, true);
+        element.setAutofilled(true);
+        break;
+      }
+    }
+  }

[Ilya Sherman, 2012/11/28 06:16:39]

Any reason not to just re-use FillForm() from form_autofill_util?

[Dan Beam, 2012/11/28 19:59:10]

That's really similar, but
a) how does this handle multiple elements with the same [autocomplete]
attribute? estade@ and I envisioned only filling the first one with the same
type.
b) it seems this won't work on non-focusable elements (i.e. [hidden] ones)?

Also, just using FillFormField() might be a middle ground.  I've added that
method to the form_autofill_util.h just for now until we decide.

[Ilya Sherman, 2012/11/29 00:08:59]

FillForm() would fill all of them.  What's the reason to only fill the first one
if the website asks for the info multiple times?
That's true, but we could add a parameter to control that.  We presumably still
don't want to fill disabled or read-only fields, though.
I think it would be best to re-use as much of the logic from the
ForEachMatchingFormField() method as possible; but if that proves to be too much
of a PITA for whatever reason, using FillFormField() is definitely better than
doing everything from scratch :)

[Dan Beam, 2012/11/29 00:51:13]

ForEachMatchingFormField also ignores select[autocomplete] at the moment -
should I remove this or is it still valid?
http://code.google.com/searchframe#OAMlx_jo-ck/src/chrome/renderer/autofill/f...

[Ilya Sherman, 2012/11/29 08:24:01]

I think you're misreading that code -- it ignores autocomplete="off" (which
might be specified on the form rather than on the field), so it simply always
treats <select> elements as potentially fillable.  It would be nice to fix that
bug, but it shouldn't affect your ability to fill the field here.  Did you test
it and find that it wasn't working?

+
+  in_flight_request_form_.finishRequestAutocomplete(
+      WebFormElement::AutocompleteResultSuccess);
   in_flight_request_form_.reset();
 }
 
+void AutofillAgent::OnRequestAutocompleteError() {
+  DCHECK(!in_flight_request_form_.isNull());
+  in_flight_request_form_.finishRequestAutocomplete(
+      WebFormElement::AutocompleteResultError);
+  in_flight_request_form_.reset();
+}
+
 void AutofillAgent::ShowSuggestions(const WebInputElement& element,
                                     bool autofill_on_empty_values,
                                     bool requires_caret_at_end,
                                     bool display_warning_if_disabled) {
   if (!element.isEnabled() || element.isReadOnly() || !element.isTextField() ||
       element.isPasswordField() || !element.suggestedValue().isEmpty())
     return;
 
   // Don't attempt to autofill with values that are too large or if filling
   // criteria are not met.
@@ skipping 123 matching lines @@
     web_view->hidePopups();
 
   HideHostPopups();
 }
 
 void AutofillAgent::HideHostPopups() {
   Send(new AutofillHostMsg_HideAutofillPopup(routing_id()));
 }
 
 }  // namespace autofill