[autofill] Fill in values on a successful run of interactive autocomplete.

chrome/browser/autofill/form_structure.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_AUTOFILL_FORM_STRUCTURE_H_
 #define CHROME_BROWSER_AUTOFILL_FORM_STRUCTURE_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 127 matching lines @@
   std::vector<AutofillField*>::const_iterator end() const {
     return fields_.end();
   }
 
   const GURL& source_url() const { return source_url_; }
 
   UploadRequired upload_required() const { return upload_required_; }
 
   virtual std::string server_experiment_id() const;
 
+  FormData* ToFormData() const;

[Ilya Sherman, 2012/11/28 06:16:39]

nit: Please change this signature to: "void ToFormData(FormData* form) const;". 
Returning raw memory is generally a bad idea as it's easy to leak the memory. 
We could return a scoped_ptr<>, but I think filling an out-param is more
Chrome-y.

Also, please add a comment describing this method.

[Dan Beam, 2012/11/28 19:59:10]

Done.

+
   bool operator==(const FormData& form) const;
   bool operator!=(const FormData& form) const;
 
  private:
   friend class FormStructureTest;
   FRIEND_TEST_ALL_PREFIXES(AutofillDownloadTest, QueryAndUploadTest);
   // 64-bit hash of the string - used in FormSignature and unit-tests.
   static std::string Hash64Bit(const std::string& str);
 
   enum EncodeRequestType {
@@ skipping 47 matching lines @@
   RequestMethod method_;
 
   // Whether the form includes any field types explicitly specified by the site
   // author, via the |autocompletetype| attribute.
   bool has_author_specified_types_;
 
   DISALLOW_COPY_AND_ASSIGN(FormStructure);
 };
 
 #endif  // CHROME_BROWSER_AUTOFILL_FORM_STRUCTURE_H_