Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1680)

Unified Diff: runtime/vm/object_test.cc

Issue 11348259: Canonicalize all integer constants taht we create by parsing a string. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/snapshot_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object_test.cc
===================================================================
--- runtime/vm/object_test.cc (revision 15426)
+++ runtime/vm/object_test.cc (working copy)
@@ -328,13 +328,13 @@
const String& smi_str = String::Handle(String::New("1"));
const String& mint1_str = String::Handle(String::New("2147419168"));
const String& mint2_str = String::Handle(String::New("-2147419168"));
- Integer& i = Integer::Handle(Integer::New(smi_str));
+ Integer& i = Integer::Handle(Integer::NewCanonical(smi_str));
EXPECT(i.IsSmi());
- i = Integer::New(mint1_str);
+ i = Integer::NewCanonical(mint1_str);
EXPECT(i.IsMint());
EXPECT(!i.IsZero());
EXPECT(!i.IsNegative());
- i = Integer::New(mint2_str);
+ i = Integer::NewCanonical(mint2_str);
EXPECT(i.IsMint());
EXPECT(!i.IsZero());
EXPECT(i.IsNegative());
@@ -456,7 +456,7 @@
EXPECT(b.IsNull());
const char* cstr = "18446744073709551615000";
const String& test = String::Handle(String::New(cstr));
- b = Bigint::New(test);
+ b = Bigint::NewCanonical(test);
const char* str = b.ToCString();
EXPECT_STREQ(cstr, str);
@@ -493,15 +493,17 @@
TEST_CASE(Integer) {
Integer& i = Integer::Handle();
- i = Integer::New(String::Handle(String::New("12")));
+ i = Integer::NewCanonical(String::Handle(String::New("12")));
EXPECT(i.IsSmi());
- i = Integer::New(String::Handle(String::New("-120")));
+ i = Integer::NewCanonical(String::Handle(String::New("-120")));
EXPECT(i.IsSmi());
- i = Integer::New(String::Handle(String::New("0")));
+ i = Integer::NewCanonical(String::Handle(String::New("0")));
EXPECT(i.IsSmi());
- i = Integer::New(String::Handle(String::New("12345678901234567890")));
+ i = Integer::NewCanonical(
+ String::Handle(String::New("12345678901234567890")));
EXPECT(i.IsBigint());
- i = Integer::New(String::Handle(String::New("-12345678901234567890111222")));
+ i = Integer::NewCanonical(
+ String::Handle(String::New("-12345678901234567890111222")));
EXPECT(i.IsBigint());
}
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/snapshot_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698