content/common/indexed_db/indexed_db_messages.h - Issue 11348254: Remove old transaction() call, proxies, and messages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/indexed_db/indexed_db_messages.h

Issue 11348254: Remove old transaction() call, proxies, and messages. (Closed) Base URL: http://git.chromium.org/chromium/src.git@create-transaction-int

Patch Set: update to ToT for landing Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/in_process_webkit/indexed_db_dispatcher_host.cc ('k') | content/common/indexed_db/proxy_webidbdatabase_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/indexed_db/indexed_db_messages.h

diff --git a/content/common/indexed_db/indexed_db_messages.h b/content/common/indexed_db/indexed_db_messages.h

index e4851d32755ad21902253a9407e9892199f6a624..0fc4baa89bcec955b127459f2ccdfc7b36ea849b 100644

--- a/content/common/indexed_db/indexed_db_messages.h

+++ b/content/common/indexed_db/indexed_db_messages.h

@@ -390,22 +390,8 @@ IPC_SYNC_MESSAGE_CONTROL3_1(IndexedDBHostMsg_DatabaseDeleteObjectStore,

int32, /* transaction_id */

WebKit::WebExceptionCode /* ec */)

-// WebIDBDatabase::transaction() message.

-// TODO: make this message async. Have the renderer create a

-// temporary ID and keep a map in the browser process of real

-// IDs to temporary IDs. We can then update the transaction

-// to its real ID asynchronously.

-// (Or make the key a pair <connection_id, transaction_id>.)

-// TODO(alecflett): Remove this as part of

-// https://bugs.webkit.org/show_bug.cgi?id=102733.

-IPC_SYNC_MESSAGE_CONTROL4_1(IndexedDBHostMsg_DatabaseTransactionOld,

- int32, /* thread_id */

- int32, /* idb_database_id */

- std::vector<int64>, /* object_stores */

- int32, /* mode */

- int32) /* idb_transaction_id */

// WebIDBDatabase::createTransaction() message.

+// TODO: make this message async.

IPC_SYNC_MESSAGE_CONTROL5_1(IndexedDBHostMsg_DatabaseCreateTransaction,

int32, /* thread_id */

int32, /* idb_database_id */