Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 11348234: Add accessibility-developer-tools to DEPS. (Closed)

Created:
8 years ago by aboxhall
Modified:
8 years ago
Reviewers:
szager1
CC:
chromium-reviews, dmazzoni
Visibility:
Public.

Description

Add accessibility-developer-tools to DEPS. BUG=162740 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169585

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add a trailing comma #

Patch Set 3 : Add trailing comma, and move library to third_party instead of chrome/third_party" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M DEPS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
aboxhall
8 years ago (2012-11-26 23:25:54 UTC) #1
szager1
lgtm with nit https://codereview.chromium.org/11348234/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/11348234/diff/1/DEPS#newcode320 DEPS:320: Var("chromium_git") + "/external/accessibility-developer-tools.git@c77344d" Please add a ...
8 years ago (2012-11-26 23:33:13 UTC) #2
aboxhall
https://codereview.chromium.org/11348234/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/11348234/diff/1/DEPS#newcode320 DEPS:320: Var("chromium_git") + "/external/accessibility-developer-tools.git@c77344d" On 2012/11/26 23:33:13, szager1 wrote: > ...
8 years ago (2012-11-26 23:51:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aboxhall@chromium.org/11348234/6001
8 years ago (2012-11-26 23:53:42 UTC) #4
commit-bot: I haz the power
Retried try job too often for step(s) content_unittests
8 years ago (2012-11-27 01:51:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aboxhall@chromium.org/11348234/6001
8 years ago (2012-11-27 03:30:01 UTC) #6
commit-bot: I haz the power
8 years ago (2012-11-27 05:09:06 UTC) #7
Message was sent while issue was closed.
Change committed as 169585

Powered by Google App Engine
This is Rietveld 408576698