Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 11348230: Merge 168531 - Return first_run_win to using the Chrome path provider to look up the user data dir. (Closed)

Created:
8 years ago by robertshield%chromium.org
Modified:
8 years ago
Reviewers:
robertshield
CC:
chromium-reviews
Visibility:
Public.

Description

Merge 168531 - Return first_run_win to using the Chrome path provider to look up the user data dir. This changed in https://chromiumcodereview.appspot.com/10837222/ which causes a regression when the user data dir is overridden via GP. BUG=161336 TEST=Have a group policy set to move the user data dir elsewhere. Ensure that repeated Chrome launches do not go through the first run flow. Review URL: https://chromiumcodereview.appspot.com/11299038 TBR=robertshield@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=169463

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
M chrome/browser/first_run/first_run_internal.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/first_run/first_run_win.cc View 2 chunks +17 lines, -8 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
robertshield%chromium.org
8 years ago (2012-11-26 19:30:12 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698